-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #325 rejectVersionIf { ... } #340
Conversation
...hub/benmanes/gradle/versions/updates/resolutionstrategy/ComponentSelectionWithCurrent.groovy
Show resolved
Hide resolved
Also: can I rename the samples from |
sure, just keep them all in a single top-level directory, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Releasing just requires bumping the version in the build.gradle
file and creating a Github Release. That makes a new tag, which is then deployed by TravisCI. You're welcome to do this too, if you want 😄.
@ghus-raba wdyt?
...hub/benmanes/gradle/versions/updates/resolutionstrategy/ComponentSelectionWithCurrent.groovy
Show resolved
Hide resolved
"examples/groovy" use Gradle 4.10.2 "examples/kotlin" uses Gradle 5.6.2 In both cases, $ ./gradlew install publishes the plugin to mavenLocal() from which the sample can pick it.
I pushed 925ad35 to avoid NPE. I refactor the smaples: "examples/groovy" use Gradle 4.10.2 and the buildScripts DSL In both cases, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...groovy/com/github/benmanes/gradle/versions/updates/resolutionstrategy/ComponentFilter.groovy
Show resolved
Hide resolved
Ok, nothing more from me. Just a reminder about this:
|
Will do it later today. Thanks to both of you. I learned a lot about Java+Kotlin+Groovy interpretability |
and v0.25 is live =) |
Replaces my first experiment, using what I learned from it and from your comments #337
Also
ComponentSelectionWithCurrent
, the@delegate
syntactic sugar does not work well in Kotlin so I implemented it manually