Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #325 rejectVersionIf { ... } #340

Merged
merged 12 commits into from
Sep 10, 2019
Merged

Conversation

jmfayard
Copy link
Collaborator

@jmfayard jmfayard commented Sep 9, 2019

Replaces my first experiment, using what I learned from it and from your comments #337

Also

  • I updated the README with the new approach of validating what is a stable version
  • I define a SAM interface that both a Groovy closure and a Kotlin function can implements properly
  • I noticed that in ComponentSelectionWithCurrent, the @delegate syntactic sugar does not work well in Kotlin so I implemented it manually

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ben-manes ben-manes requested a review from ferinagy September 9, 2019 22:06
@jmfayard
Copy link
Collaborator Author

jmfayard commented Sep 9, 2019

Also: can I rename the samples from examples and examples/kotlin to sample-groovy and sample-kotlin? I think that would make more sense. And should I add the gradle wrapper and jars there?

@ben-manes
Copy link
Owner

sure, just keep them all in a single top-level directory, e.g. examples, and put each sample underneath it.

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@ben-manes ben-manes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Releasing just requires bumping the version in the build.gradle file and creating a Github Release. That makes a new tag, which is then deployed by TravisCI. You're welcome to do this too, if you want 😄.

@ghus-raba wdyt?

README.md Outdated Show resolved Hide resolved
examples/build.gradle Outdated Show resolved Hide resolved
"examples/groovy" use Gradle 4.10.2
"examples/kotlin" uses Gradle 5.6.2

In both cases, $ ./gradlew install publishes the plugin to mavenLocal() from which the sample can pick it.
@jmfayard
Copy link
Collaborator Author

I pushed 925ad35 to avoid NPE.

I refactor the smaples:

"examples/groovy" use Gradle 4.10.2 and the buildScripts DSL
"examples/kotlin" uses Gradle 5.6.2 and the plugins DSL

In both cases, $ ./gradlew install publishes the plugin to mavenLocal() from which the sample can pick it.

Copy link
Collaborator

@ferinagy ferinagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
@ferinagy
Copy link
Collaborator

Ok, nothing more from me. Just a reminder about this:

Releasing just requires bumping the version in the build.gradle file and creating a Github Release. That makes a new tag, which is then deployed by TravisCI. You're welcome to do this too, if you want 😄.

@jmfayard
Copy link
Collaborator Author

Will do it later today. Thanks to both of you. I learned a lot about Java+Kotlin+Groovy interpretability

@jmfayard jmfayard merged commit 5f89fa2 into ben-manes:master Sep 10, 2019
@jmfayard jmfayard deleted the 325-bis branch September 10, 2019 16:17
@ben-manes
Copy link
Owner

and v0.25 is live =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants