WIP: rejectVersionIf { }

[jmfayard]

I had a first try at implementing #325

rejectVersionIf { current: ComponentSelectionWithCurrent ->
        isNonStable(current.candidate.version) || !isNonStable(current.currentVersion)
}

It would be better if we can change the syntax to this but I don't know how to do it:

rejectVersionIf { candidate: ModuleComponentIdentifier ->
        isNonStable(candidate.version) || !isNonStable(currentVersion)
}

isNonStable being defined as this:

fun isNonStable(version: String): Boolean {
  val stableKeyword = listOf("RELEASE", "FINAL", "GA").any { version.toUpperCase().contains(it) }
  val regex = "^[0-9,.v-]+$".toRegex()
  val isStable = stableKeyword || regex.matches(version)
  return isStable.not()
}

Since my Groovy skills are closed to zero, I tried to upgrade Gradle so that at least that part is familiar for me.

Because of the Gradle update, one test is not working anymore https://scans.gradle.com/s/unwddfvrt5xak

    > Could not find method componentSelection() for arguments [build_6aatid6bxisq96bm8bf31j5zh$_run_closure3$_closure5@243ebea0] on root project 'junit8907024250739898265' of type org.gradle.api.Project.

dependencyUpdates.resolutionStrategy = componentSelection {
        all(new Rule())
   }
}

I have also run ./gradlew publish and then use the artifact in my own plugin

https://github.com/jmfayard/buildSrcVersions/pull/62/files

One part of this is also wrong:

Cannot change dependencies of configuration ':classpath' after it has been resolved.

https://gist.github.com/jmfayard/f8455c2cdc658035e8d542ecf0f841ac

[ben-manes]

If you use gradle install it will install into the local maven repository. Then you can use mavenLocal() in your repository to reference it, if you bump the version up. That's how I do ad hoc testing in the examples build, to see it in action.

I think Gradle changed the version of Groovy which is backwards incompatible, so we stayed on an old version which is forward compatible. So there could be some weird interaction there.

If you drop all your Gradle changes and use mavenLocal, does all of this work right?

[ben-manes]

Sounds like you can now drop the these now that the delegation is fixed. Does it work like this?

resolutionStrategy {
  strategy.componentSelection {
    all {
      if (filter.transform(current)) {
        current.reject("Rejected")
      }
    }
  }
}

[ben-manes]

oh, maybe not without losing the typesafe checking

[ferinagy]

This is causing the fail in the test, because the closure is executed without correct arguments and delegates during validation. Something similar seems to have happened in 3cce551, where they removed the annotation from the outputFormatter field.

[ferinagy]

I think this could be the cause of Cannot change dependencies of configuration ':classpath' after it has been resolved. Try:

def configurations = []
configurations.addAll(proj.configurations)
configurations.addAll(proj.buildscript.configurations)
[proj, configurations as Set]