Mesh preview rc (Azure#29)

* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (Azure#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (Azure#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (Azure#233) * Checks for license presence while disregarding '#\n' (Azure#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (Azure#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (Azure#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (Azure#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming
belmaiastar · Jul 20, 2018 · 5ee972a · 5ee972a
1 parent 7ba0484
commit 5ee972a
Show file tree

Hide file tree

Showing 17 changed files with 212 additions and 58 deletions.
diff --git a/.flake8 b/.flake8
@@ -7,3 +7,16 @@ ignore =
     F401,  # imported but unused, too many violations, to be removed in the future
     F811,  # redefinition of unused, to be removed in the future
     C901   # code flow is too complex, too many violations, to be removed in the future
+exclude = 
+    */vendored_sdks
+    docs
+    scripts
+    ./src/eventgrid/azext_eventgrid/mgmt/eventgrid
+    ./src/botservice/azext_bot/botservice
+    ./src/dns/azext_dns/dns
+    ./src/managementgroups/azext_managementgroups/managementgroups
+    ./src/managementpartner/azext_managementpartner/managementpartner
+    ./src/rdbms_vnet/azext_rdbms_vnet/postgresql
+    ./src/rdbms_vnet/azext_rdbms_vnet/mysql
+    ./src/signalr/azext_signalr/signalr
+    ./src/subscription/azext_subscription/subscription
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -9,4 +9,4 @@ This checklist is used to make sure that common guidelines for a pull request ar
 
 For new extensions:
 
-- [ ] My extension description/summary conforms to the [Extension Summary Guidelines](https://github.com/Azure/azure-cli-extensions/blob/master/docs/extension_summary_guidelines.md).
+- [ ] My extension description/summary conforms to the [Extension Summary Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/extensions/extension_summary_guidelines.md).
diff --git a/.travis.yml b/.travis.yml
@@ -4,16 +4,20 @@ language: python
 services:
   - docker
 install:
-    - pip install pylint flake8 requests wheel==0.30.0 -q
+    - pip install pylint==1.9.2 flake8 requests wheel==0.30.0 -q
 jobs:
   include:
-    - stage: verify
+    - stage: precheck
       env: PURPOSE='SourceStatic'
-      script: travis_wait ./scripts/ci/test_static.sh
+      script: ./scripts/ci/test_static.sh
       python: 2.7
-    - stage: verify
+    - stage: precheck
       env: PURPOSE='SourceStatic'
-      script: travis_wait ./scripts/ci/test_static.sh
+      script: ./scripts/ci/test_static.sh
+      python: 3.6
+    - stage: precheck
+      env: PURPOSE='IndexVerify'
+      script: python ./scripts/ci/test_index.py -v
       python: 3.6
     - stage: verify
       env: PURPOSE='SourceTests'
@@ -23,10 +27,6 @@ jobs:
       env: PURPOSE='SourceTests'
       script: travis_wait 40 ./scripts/ci/test_source.sh
       python: 3.6
-    - stage: verify
-      env: PURPOSE='IndexVerify'
-      script: python ./scripts/ci/test_index.py -v
-      python: 3.6
     - stage: verify
       env: PURPOSE='IndexRefDocVerify'
       script: ./scripts/ci/test_index_ref_doc.sh

diff --git a/scripts/ci/test_source.py b/scripts/ci/test_source.py
@@ -12,7 +12,7 @@
 import tempfile
 import unittest
 import shutil
-from subprocess import check_call, CalledProcessError, PIPE
+from subprocess import check_output, check_call, CalledProcessError
 
 import mock
 from wheel.install import WHEEL_INFO_RE
@@ -76,8 +76,7 @@ def test_source_wheels(self):
             if not os.path.isfile(os.path.join(s, 'setup.py')):
                 continue
             try:
-                check_call(['python', 'setup.py', 'bdist_wheel', '-q', '-d', built_whl_dir],
-                           cwd=s, stdout=PIPE, stderr=PIPE)
+                check_output(['python', 'setup.py', 'bdist_wheel', '-q', '-d', built_whl_dir], cwd=s)
             except CalledProcessError as err:
                 self.fail("Unable to build extension {} : {}".format(s, err))
         for filename in os.listdir(built_whl_dir):

diff --git a/scripts/ci/test_static.sh b/scripts/ci/test_static.sh
@@ -14,7 +14,7 @@ pylint ./src/*/azext_*/ --ignore=$PYLINT_EXCLUDES,vendored_sdks --ignore-pattern
 
 echo "Pylint OK."
 echo "Running flake8 on extensions..."
-flake8 --statistics --exclude=$FLAKE8_EXCLUDES,vendored_sdks --append-config=./.flake8 ./src/*/azext_*/
+flake8 --statistics --append-config=./.flake8 ./src/*/azext_*/
 echo "Flake8 OK."
 
 # Run pylint/flake8 on CI files
@@ -23,4 +23,4 @@ flake8 --append-config=./.flake8 ./scripts/ci/*.py
 
 # Other static checks
 python ./scripts/ci/verify_codeowners.py
-python ./scripts/ci/verify_license.py 'src/storage-preview/azext_storage_preview/vendored_sdks'
+python ./scripts/ci/verify_license.py
diff --git a/scripts/ci/verify_license.py b/scripts/ci/verify_license.py
@@ -14,22 +14,8 @@
 REPO_ROOT = get_repo_root()
 SRC_DIR = os.path.join(REPO_ROOT, 'src')
 
-LICENSE_HEADER = """# --------------------------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for license information.
-# --------------------------------------------------------------------------------------------
-"""
-
-AUTOREST_LICENSE_HEADER = """# --------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for
-# license information.
-#
-# Code generated by Microsoft (R) AutoRest Code Generator.
-# Changes may cause incorrect behavior and will be lost if the code is
-# regenerated.
-# --------------------------------------------------------------------------
-"""
+LICENSE_HEADER = ("Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. "
+                  "See License.txt in the project root for license information.")
 
 
 def main(args):
@@ -45,7 +31,8 @@ def main(args):
         for python_file in file_itr:
             with open(python_file, 'r') as f:
                 file_text = f.read().replace('\r\n', '\n')
-                if file_text and (LICENSE_HEADER not in file_text and AUTOREST_LICENSE_HEADER not in file_text):
+                file_text = file_text.replace('\n#', '')
+                if file_text and (LICENSE_HEADER not in file_text):
                     files_without_header.append(os.path.join(current_dir, python_file))
 
     if files_without_header:

diff --git a/scripts/refdoc/azhelpgen/azhelpgen.py b/scripts/refdoc/azhelpgen/azhelpgen.py
@@ -33,7 +33,7 @@ def get_extension_help_files(cli_ctx):
     print('FOUND {} command(s) from the extension.'.format(len(cmd_table)))
     for cmd_name in cmd_table:
             invoker.commands_loader.load_arguments(cmd_name)
-    invoker.parser.load_command_table(invoker.commands_loader.command_table)
+    invoker.parser.load_command_table(invoker.commands_loader)
 
     parser_keys = []
     parser_values = []
@@ -44,10 +44,12 @@ def get_extension_help_files(cli_ctx):
         if cmd not in sub_parser_keys:
             sub_parser_keys.append(cmd)
             sub_parser_values.append(parser)
+    help_ctx = cli_ctx.help_cls(cli_ctx=cli_ctx)
     help_files = []
     for cmd, parser in zip(sub_parser_keys, sub_parser_values):
         try:
-            help_file = GroupHelpFile(cmd, parser) if _is_group(parser) else CliCommandHelpFile(cmd, parser)
+            help_file = GroupHelpFile(help_ctx, cmd, parser) if _is_group(parser) \
+                else CliCommandHelpFile(help_ctx, cmd, parser)
             help_file.load(parser)
             help_files.append(help_file)
         except Exception as ex:
@@ -73,6 +75,8 @@ def make_rst(self):
             yield ''
             yield '{}:summary: {}'.format(INDENT, help_file.short_summary)
             yield '{}:description: {}'.format(INDENT, help_file.long_summary)
+            if help_file.deprecate_info:
+                yield '{}:deprecated: {}'.format(INDENT, help_file.deprecate_info._get_message(help_file.deprecate_info))
             yield ''
 
             if is_command and help_file.parameters:
@@ -84,6 +88,8 @@ def make_rst(self):
                     yield '{}.. cliarg:: {}'.format(INDENT, arg.name)
                     yield ''
                     yield '{}:required: {}'.format(DOUBLEINDENT, arg.required)
+                    if arg.deprecate_info:
+                        yield '{}:deprecated: {}'.format(DOUBLEINDENT, arg.deprecate_info._get_message(arg.deprecate_info))
                     short_summary = arg.short_summary or ''
                     possible_values_index = short_summary.find(' Possible values include')
                     short_summary = short_summary[0:possible_values_index

diff --git a/scripts/refdoc/cligroup/cligroup.py b/scripts/refdoc/cligroup/cligroup.py
@@ -32,29 +32,35 @@ def get_index_text(self, modname, name):
 
 class CliGroupDirective(CliBaseDirective):
     doc_field_types = copy.copy(cli_field_types)
-    doc_field_types.append(
+    doc_field_types.extend([
         Field('docsource', label='Doc Source', has_arg=False,
-                   names=('docsource', 'documentsource'))
-    )
+              names=('docsource', 'documentsource')),
+        Field('deprecated', label='Deprecated', has_arg=False,
+              names=('deprecated'))
+    ])
 
 class CliCommandDirective(CliBaseDirective):
     doc_field_types = copy.copy(cli_field_types)
-    doc_field_types.append(
+    doc_field_types.extend([
         Field('docsource', label='Doc Source', has_arg=False,
-                   names=('docsource', 'documentsource'))
-    )
+              names=('docsource', 'documentsource')),
+        Field('deprecated', label='Deprecated', has_arg=False,
+              names=('deprecated'))
+    ])
 
 class CliArgumentDirective(CliBaseDirective):
     doc_field_types = copy.copy(cli_field_types)
     doc_field_types.extend([
         Field('required', label='Required', has_arg=False,
-            names=('required')),
+              names=('required')),
         Field('values', label='Allowed values', has_arg=False,
-            names=('values', 'choices', 'options')),
+              names=('values', 'choices', 'options')),
         Field('default', label='Default value', has_arg=False,
-            names=('default')),
+              names=('default')),
         Field('source', label='Values from', has_arg=False,
-            names=('source', 'sources'))
+              names=('source', 'sources')),
+        Field('deprecated', label='Deprecated', has_arg=False,
+              names=('deprecated'))
      ])
 
 class CliExampleDirective(CliBaseDirective):

diff --git a/src/mesh/HISTORY.rst b/src/mesh/HISTORY.rst
@@ -3,6 +3,13 @@
 Release History
 ===============
 
+
+0.9.0 (2018-07-16)
+++++++++++++++++++
+
+* Added diagnostic output to deployment create command.
+
+
 0.8.0 (2018-07-09)
 ++++++++++++++++++
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,4 +9,4 @@ This checklist is used to make sure that common guidelines for a pull request ar

		For new extensions:

		- [ ] My extension description/summary conforms to the [Extension Summary Guidelines](https://github.com/Azure/azure-cli-extensions/blob/master/docs/extension_summary_guidelines.md).
		- [ ] My extension description/summary conforms to the [Extension Summary Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/extensions/extension_summary_guidelines.md).