fix issue with publishing to bot #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
tjprescott
approved these changes
Jun 13, 2018
williexu
suggested changes
Jun 14, 2018
src/botservice/azext_bot/custom.py
Outdated
| @@ -233,7 +233,7 @@ def create_app(cmd, client, resource_group_name, resource_name, description, kin | |||
| return create_bot_json(cmd, client, resource_group_name, resource_name, app_password=password) | |||
|
|
|||
|
|
|||
| def publish_app(cmd, _, resource_group_name, resource_name, git_url=None, git_token=None, git_branch='master', # pylint: disable=inconsistent-return-statements | |||
| def publish_app(cmd, client, resource_group_name, resource_name, git_url=None, git_token=None, git_branch='master', # pylint: disable=inconsistent-return-statements | |||
There was a problem hiding this comment.
This parameter is not being used in the function. You may want to remove it entirely.
There was a problem hiding this comment.
@williexu i am going to be making change to this code path in my next iteration shortly when i will need the client. So instead of removing this now and readding (and changing the extension package at the source blob again), can we get this in for now?
There was a problem hiding this comment.
oh i see why you suggest this..the build is detecting hte unused parameter and failing...i will remove it
williexu
approved these changes
Jun 14, 2018
belmaiastar
added a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227)
belmaiastar
pushed a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (Azure#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (Azure#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (Azure#233) * Checks for license presence while disregarding '#\n' (Azure#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (Azure#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (Azure#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (Azure#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming
williexu
pushed a commit
that referenced
this pull request
Jul 21, 2018
* Service Fabric Mesh - Public Preview (#22) * Mesh public preview (#26) * Private Preview 4 * Fix CI check * Use future print * Merge from master (#27) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * [0.8.0] Update SDK to Mesh namespace * Use new namespace * Run tests * iteration1 comments * new lines * Drop commands for legacy resources * Add license header * Comments * Delete sbz * Api version * fix history * Mesh preview rc (#29) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (#233) * Checks for license presence while disregarding '#\n' (#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming * Add to index.json * Update module name * Update author name * Fix CI error * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.