Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Removed Unused Functions:
functions.get_columns
andfunctions.get_score
as they were unused in the codebase.Modernized Import Handling:
src/kinex/resources/__init__.py
to use the modernfiles()
method fromimportlib.resources
instead of the deprecatedpath()
method.Fixed Sequence Handling:
PH_CAPITAL = "(PH)"
insrc/kinex/sequence.py
to handle cases whereseq.upper()
withfavorability=False
resulted in invalid separators (e.g.,(PH)
), which were mistakenly filtered out.Improved Stability:
check_zeros
parameter to the 2x2 table implementation to prevent division by zero errors whenshift_zeros=False
.Improved
fisher_statistics
function:Enhanced Test Coverage:
enrichment
,sequence
,score
, andtable2x2
modules.kinex
andio
modules.Fixes #7