Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scoring matrix downloading process #5

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

clonder
Copy link
Contributor

@clonder clonder commented Nov 19, 2024

Automatic Downloading: Matrix files are automatically downloaded if missing, ensuring up-to-date resources.
Caching: Downloaded files are cached locally, reducing redundant downloads and improving performance.

@Accio
Copy link
Contributor

Accio commented Nov 20, 2024

Thanks @clonder! I will have a look.

@alexandra-valeanu
Copy link
Collaborator

Hey, @clonder! Thank you for working on Kinex!

I tested the changes you made and encountered some errors:
IMG_7947

Consider adding "requests" to dependencies in pyproject.toml

After I install the "requests" package I get the following:
IMG_5138

Here is a link to how the [project.urls] are used: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#urls
Consider adding the links to resources or store them in variables.

@clonder
Copy link
Contributor Author

clonder commented Nov 24, 2024

Hi @alexandra-valeanu,

Thank you for reviewing this package. I’ve added resources to the dependencies—sorry for the inconvenience.

I was initially testing this within the same directory, so the pyproject.toml was always in the path. My plan was to include it in the build when publishing to PyPI in the next iteration.

We can use resources also, I’ve updated it to use the configuration files as per this commit.

Thanks again for your feedback!

@alexandra-valeanu
Copy link
Collaborator

Hey @clonder! All good, it works now. Could you change the documentation in docs/chapters/features/usage.rst?

@clonder
Copy link
Contributor Author

clonder commented Nov 24, 2024

Sure!

=0.12. Outdated Show resolved Hide resolved
@Accio
Copy link
Contributor

Accio commented Dec 5, 2024

thank you both!

@Accio Accio merged commit 650bff8 into bedapub:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants