add typehint #286
add typehint #286
Conversation
add composer require ext add throw phpdoc
|
This change made that the whole beberlei/assert package now requires the intl extension to be installed. I failed to find how this library is dependent on intl. Surely, not all features depend on it to make it whole package's dependency? |
|
Ok, found out that #268 and #269 make that It's what I'd call an optional dependency though. The The intl extension is still not being commonly installed as for most projects it's of no benefit. IMO It's not nice to force people to install it because an assertion library "needs" it for some edge cases. |
Fixes #288. While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it.
|
This is actually a BC break, making it impossible to properly extend Resolving these can be kinda trivial, but still... |
* Remove ext-intl as a required extension, making it a suggested extension for use with Assertion::count(), Assertion::isCountable(), Assertion::minCount(), and Assertion::maxCount() to operate on ResourceBundles. * Correct @method return typehint for LazyAssertion chaining * Restored `\Assert\Assertion::createException()` signature to 3.2.2. Sincerely apologies to the BC break. * Fix docblock typehint * Prepare v3.2.4 * Remove a hard dependency on the intl extension (#289) Fixes #288. While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it. * Fix docblocks for `all` to show that they are expected to receive an array of things * Preapare v3.2.5 * Make `Assert\Assertion::stringify()` UTF-8 safe. * Prepare v3.2.6 * Reinstate LazyAssertion docblock * ## 3.2.7 - 2019-12-19 ### Fixes - Reinstated the `@method` return type for `Assert\LazyAssertion` methods to show that the return type is `LazyAssertion`. * Fixes Co-authored-by: Richard Quadling <[email protected]> Co-authored-by: Jakub Zalas <[email protected]>
add composer require ext
add throw phpdoc