Skip to content

Commit

Permalink
Remove a hard dependency on the intl extension (#289)
Browse files Browse the repository at this point in the history
Fixes #288.

While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed.

However, the intl extension dependency is a soft dependency.
The package does not need intl for most of its features and can safely work without it.
  • Loading branch information
jakzal authored and rquadling committed Oct 10, 2019
1 parent 200ecc8 commit d4207ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
},
"require": {
"php": "^7",
"ext-intl": "*",
"ext-simplexml": "*",
"ext-mbstring": "*",
"ext-ctype": "*",
Expand Down
3 changes: 2 additions & 1 deletion tests/Assert/Tests/AssertTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,8 @@ public function testValidCount()
* @requires extension intl
*/
public function testValidCountWithIntlResourceBundle()
{ // Test ResourceBundle counting using resources generated for PHP testing of ResourceBundle
{
// Test ResourceBundle counting using resources generated for PHP testing of ResourceBundle
// https://github.com/php/php-src/commit/8f4337f2551e28d98290752e9ca99fc7f87d93b5
$this->assertTrue(Assertion::count(new ResourceBundle('en_US', __DIR__.'/_files/ResourceBundle'), 6));
}
Expand Down

0 comments on commit d4207ed

Please sign in to comment.