Skip to content

Commit

Permalink
fix: remove duplicate vestigial Apply on Play menu item
Browse files Browse the repository at this point in the history
Closes: #70
  • Loading branch information
bdunderscore committed Nov 10, 2023
1 parent 753319d commit b1999c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

### Removed
- Removed a vestigial "Avatar Toolkit -> Apply on Play" menu item, which didn't do anything when selected. (#70)

### Security

Expand Down
10 changes: 0 additions & 10 deletions Editor/ApplyOnPlay.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ namespace nadena.dev.ndmf
[InitializeOnLoad]
internal static class ApplyOnPlay
{
private const string MENU_NAME = "Tools/Avatar Toolkit/Apply on Play";

/**
* We need to process avatars before lyuma's av3 emulator wakes up and processes avatars; it does this in Awake,
* so we have to do our processing in Awake as well. This seems to work fine when first entering play mode, but
Expand All @@ -55,7 +53,6 @@ static ApplyOnPlay()
{
EditorApplication.playModeStateChanged += OnPlayModeStateChanged;
ApplyOnPlayGlobalActivator.OnDemandProcessAvatar = MaybeProcessAvatar;
//EditorApplication.delayCall += () => Menu.SetChecked(MENU_NAME, ModularAvatarSettings.applyOnPlay);
}

private static void MaybeProcessAvatar(ApplyOnPlayGlobalActivator.OnDemandSource source,
Expand All @@ -69,13 +66,6 @@ private static void MaybeProcessAvatar(ApplyOnPlayGlobalActivator.OnDemandSource
}
}

[MenuItem(MENU_NAME)]
private static void ToggleApplyOnPlay()
{
//ModularAvatarSettings.applyOnPlay = !ModularAvatarSettings.applyOnPlay;
//Menu.SetChecked(MENU_NAME, ModularAvatarSettings.applyOnPlay);
}

private static void OnPlayModeStateChanged(PlayModeStateChange obj)
{
if (obj == PlayModeStateChange.EnteredPlayMode)
Expand Down

0 comments on commit b1999c6

Please sign in to comment.