Merge branch 'develop' into feat/add_mee

bcnmy · Jan 16, 2025 · 7911577 · 7911577
2 parents b26c193 + 3b6a9a1
commit 7911577
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # @biconomy/sdk
 
+## 0.0.28
+
+### Patch Changes
+
+- Sudo fallback for empty rules
+
+## 0.0.27
+
+### Patch Changes
+
+- useRegistry false attestation fix
+
 ## 0.0.26
 
 ### Patch Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@biconomy/sdk",
-  "version": "0.0.26",
+  "version": "0.0.28",
   "author": "Biconomy",
   "repository": "github:bcnmy/sdk",
   "main": "./dist/_cjs/index.js",

diff --git a/src/sdk/clients/createBicoPaymasterClient.test.ts b/src/sdk/clients/createBicoPaymasterClient.test.ts
@@ -25,7 +25,7 @@ import {
   createSmartAccountClient
 } from "./createSmartAccountClient"
 
-describe("bico.paymaster", async () => {
+describe.skip("bico.paymaster", async () => {
   // describe.runIf(paymasterTruthy())("bico.paymaster", async () => {
   let network: NetworkConfig
 
@@ -163,6 +163,7 @@ describe("bico.paymaster", async () => {
     })
     const receipt = await nexusClient.waitForUserOperationReceipt({ hash })
 
+    console.log(receipt, "receipt")
     expect(receipt.success).toBe("true")
 
     // Get final balance

diff --git a/src/sdk/modules/smartSessionsValidator/decorators/preparePermission.ts b/src/sdk/modules/smartSessionsValidator/decorators/preparePermission.ts
@@ -86,7 +86,10 @@ export const getPermissionAction = async ({
     // })
     // policyData.push(timeFramePolicyData)
 
-    if (actionPolicyInfo.rules && actionPolicyInfo.rules.length > 0) {
+    const hasValidRules =
+      actionPolicyInfo?.rules && actionPolicyInfo?.rules?.length > 0
+
+    if (hasValidRules) {
       const actionConfig = createActionConfig(
         actionPolicyInfo.rules ?? [],
         actionPolicyInfo.valueLimit
@@ -100,7 +103,7 @@ export const getPermissionAction = async ({
     }
 
     // create sudo policy here..
-    if (actionPolicyInfo.sudo) {
+    if (actionPolicyInfo.sudo || !hasValidRules) {
       const sudoPolicy = getSudoPolicy()
       policyData.push(sudoPolicy)
     }

diff --git a/src/sdk/modules/smartSessionsValidator/toSmartSessionValidator.enable.mode.test.ts b/src/sdk/modules/smartSessionsValidator/toSmartSessionValidator.enable.mode.test.ts
@@ -117,7 +117,9 @@ describe.skip("modules.smartSessions.enable.mode.dx", async () => {
   })
 
   test("full smart sessions enable mode example", async () => {
-    const uninitializedSmartSessions = getSmartSessionsValidator({})
+    const uninitializedSmartSessions = getSmartSessionsValidator({
+      useRegistry: false
+    })
 
     const isInstalled = await nexusClient.isModuleInstalled({
       module: uninitializedSmartSessions

diff --git a/src/sdk/modules/smartSessionsValidator/toSmartSessionsValidator.ts b/src/sdk/modules/smartSessionsValidator/toSmartSessionsValidator.ts
@@ -108,7 +108,8 @@ export const toSmartSessionsValidator = (
   } = parameters
 
   const initData = initData_ ?? getUsePermissionInitData(initArgs_)
-  const moduleInitData = moduleInitData_ ?? getSmartSessionsValidator({})
+  const moduleInitData =
+    moduleInitData_ ?? getSmartSessionsValidator({ useRegistry: false })
 
   return toModule({
     ...parameters,

diff --git a/src/test/testUtils.ts b/src/test/testUtils.ts
@@ -44,7 +44,7 @@ import type { TestFileNetworkType } from "./testSetup"
 config()
 
 const BASE_SEPOLIA_RPC_URL =
-  "https://virtual.base-sepolia.rpc.tenderly.co/6ccdd33d-d8f4-4476-8d37-63ba0ed0ea8f"
+  "https://virtual.base-sepolia.rpc.tenderly.co/25344426-d008-45d9-ac9f-93910c696110"
 
 type AnvilInstance = ReturnType<typeof anvil>
 type BundlerInstance = ReturnType<typeof alto>