chore: sudo policy fallback for empty rules

bcnmy · Jan 16, 2025 · 3b6a9a1 · 3b6a9a1
1 parent fa4b52d
commit 3b6a9a1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @biconomy/sdk
 
+## 0.0.28
+
+### Patch Changes
+
+- Sudo fallback for empty rules
+
 ## 0.0.27
 
 ### Patch Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@biconomy/sdk",
-  "version": "0.0.27",
+  "version": "0.0.28",
   "author": "Biconomy",
   "repository": "github:bcnmy/sdk",
   "main": "./dist/_cjs/index.js",

diff --git a/src/sdk/modules/smartSessionsValidator/decorators/preparePermission.ts b/src/sdk/modules/smartSessionsValidator/decorators/preparePermission.ts
@@ -86,7 +86,10 @@ export const getPermissionAction = async ({
     // })
     // policyData.push(timeFramePolicyData)
 
-    if (actionPolicyInfo.rules && actionPolicyInfo.rules.length > 0) {
+    const hasValidRules =
+      actionPolicyInfo?.rules && actionPolicyInfo?.rules?.length > 0
+
+    if (hasValidRules) {
       const actionConfig = createActionConfig(
         actionPolicyInfo.rules ?? [],
         actionPolicyInfo.valueLimit
@@ -100,7 +103,7 @@ export const getPermissionAction = async ({
     }
 
     // create sudo policy here..
-    if (actionPolicyInfo.sudo) {
+    if (actionPolicyInfo.sudo || !hasValidRules) {
       const sudoPolicy = getSudoPolicy()
       policyData.push(sudoPolicy)
     }

diff --git a/src/test/testUtils.ts b/src/test/testUtils.ts
@@ -43,7 +43,7 @@ import type { TestFileNetworkType } from "./testSetup"
 config()
 
 const BASE_SEPOLIA_RPC_URL =
-  "https://virtual.base-sepolia.rpc.tenderly.co/6ccdd33d-d8f4-4476-8d37-63ba0ed0ea8f"
+  "https://virtual.base-sepolia.rpc.tenderly.co/25344426-d008-45d9-ac9f-93910c696110"
 
 type AnvilInstance = ReturnType<typeof anvil>
 type BundlerInstance = ReturnType<typeof alto>