-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21570 - Display CAS supplier number and email address for a short name #3014
Conversation
import PaymentService from '@/services/payment.services' | ||
|
||
export default defineComponent({ | ||
name: 'ShortNamePatchDialog', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend choosing a better name, ShortNamePatchDialog
doesn't really give you any info
ShortNameFinancialDialog
? there's probably a better name out there
Enter the contact email provided in the client's Direct Deposit Application form | ||
</p> | ||
<p v-if="shortNamePatchDialogType === 'CAS_SUPPLIER_NUMBER'"> | ||
Enter the supplier number created in CAS for this short name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
computed
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highlevel LGTM
|
Issue #:
bcgov/entity#21570
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).