Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21570 - Display CAS supplier number and email address for a short name #3014

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:
bcgov/entity#21570

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Fix
import PaymentService from '@/services/payment.services'

export default defineComponent({
name: 'ShortNamePatchDialog',
Copy link
Collaborator

@seeker25 seeker25 Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend choosing a better name, ShortNamePatchDialog doesn't really give you any info

ShortNameFinancialDialog? there's probably a better name out there

Enter the contact email provided in the client's Direct Deposit Application form
</p>
<p v-if="shortNamePatchDialogType === 'CAS_SUPPLIER_NUMBER'">
Enter the supplier number created in CAS for this short name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computed?

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlevel LGTM

Copy link

@rodrigo-barraza rodrigo-barraza merged commit 6855847 into bcgov:main Sep 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants