Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short Name Details - Display CAS supplier number and email address for a short name. #21570

Closed
danaannab opened this issue May 31, 2024 · 8 comments
Assignees
Labels
EFT Pay Work for Pay Team

Comments

@danaannab
Copy link
Collaborator

danaannab commented May 31, 2024

https://www.figma.com/design/Y1PWkuB8II5lxdDdUq67Aj/Electronic-Funds-Transfer?node-id=2899-24638&t=Pf154RjpPeMIrVoM-4

Add top right of a short name detail page, supplier record # and email address can be viewed and edited.

Look up pattern for Supplier number format

Assumes backend routes and data model is already covered by previous ticket #21535

@danaannab danaannab added the Pay Work for Pay Team label May 31, 2024
@danaannab danaannab changed the title Update Supplier Record # Short Name Details - Update Supplier Record # May 31, 2024
@ethantspitt
Copy link
Collaborator

Do we want to set a limit to only certain user group can click edit?

@JohnamLane
Copy link
Collaborator

@ethantspitt ethantspitt changed the title Short Name Details - Update Supplier Record # Short Name Details - Display CAS supplier number and email address for a short name. Jun 5, 2024
@Jxio Jxio added the EFT label Jul 24, 2024
@rodrigo-barraza rodrigo-barraza self-assigned this Sep 4, 2024
@lizhuomeng71
Copy link
Collaborator

Functionality looks good, and I can see the validation checks are in place. Please update the implementation to display an error message when validation fails.

@lizhuomeng71
Copy link
Collaborator

Bug Report: UI/UX and Validation Issues

Account Name:

Expected: Font size should be 24px, line height 32px.
Actual: Font size is 32px, line height is 40px.
Property (e.g., CAS Supplier Number: 4040):

Expected: Font size should be 18px.
Actual: Font size is 16px.
Edit Icon:

Expected: There should be a 16px gap before the edit icon, and the pencil icon should be unfilled.
Actual: There is no gap, and the pencil icon is filled.
Email Field - Initial Pop Up:

Expected: The email field should be in a clear state when first popped up.
Actual: The email field is in an error state when first popped up.
Email Field - Validation:

Expected: When validation fails, the user should not be able to save.
Actual: The user is still able to save, even when validation fails.
Email Field - Text Wrapping:

Expected: Long email addresses should wrap within the field.
Actual: Long email addresses start on a new line instead of wrapping.

@lizhuomeng71
Copy link
Collaborator

Everything is resolved except for the white header background height:

It should have a 40px padding at the bottom.
The height of the white background does not adjust when the email is too long and wraps to the second line.

image.png

@lizhuomeng71
Copy link
Collaborator

lizhuomeng71 commented Oct 10, 2024

on test, I am still not able to view the new white space, was the latest change pushed?

@seeker25
Copy link
Collaborator

seeker25 commented Oct 10, 2024

Look at the version number at the bottom of the footer, does it match the PR that mentions this issue?

image

image

image

@lizhuomeng71
Copy link
Collaborator

issue is verified

@PCC199 PCC199 closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EFT Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

8 participants