Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a page for bookmark. #1881

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

pwei1018
Copy link
Collaborator

Issue #:
bcgov/entity#10248

Description of changes:

  1. Add a bookmark page to handle the authentication issue when the customer bookmark an auth-web page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@pwei1018 pwei1018 force-pushed the 10248-bookmark-page branch from c649160 to 9617dac Compare January 18, 2022 06:41
@pwei1018 pwei1018 added the devops technical continuous improvement label Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1881 (90dedf5) into main (c4e1cac) will decrease coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   80.47%   79.95%   -0.53%     
==========================================
  Files         304      311       +7     
  Lines       10499    10629     +130     
  Branches      449      485      +36     
==========================================
+ Hits         8449     8498      +49     
- Misses       2050     2131      +81     
Flag Coverage Δ
authweb 43.59% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth-web/src/views/auth/SigninView.vue 100.00% <ø> (ø)
...auth/account-settings/account-info/AccountInfo.vue 54.54% <0.00%> (-28.79%) ⬇️
...components/auth/create-account/UserProfileForm.vue 57.14% <0.00%> (-22.86%) ⬇️
...mponents/auth/manage-business/EntityManagement.vue 27.27% <0.00%> (-22.73%) ⬇️
...src/components/auth/common/AccountBusinessType.vue 50.00% <0.00%> (-4.55%) ⬇️
auth-web/src/store/modules/staff.ts 29.58% <0.00%> (-3.31%) ⬇️
auth-web/src/store/modules/business.ts 18.11% <0.00%> (-2.07%) ⬇️
...h-web/src/components/auth/mixins/NextPageMixin.vue 6.25% <0.00%> (-0.90%) ⬇️
auth-web/src/store/modules/org.ts 27.53% <0.00%> (-0.47%) ⬇️
auth-web/src/services/user.services.ts 4.34% <0.00%> (-0.42%) ⬇️
... and 26 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@pwei1018 pwei1018 merged commit 9f05e07 into bcgov:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops technical continuous improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants