Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #255: Refactor frontend and add validation placeholder, support in depth form change #262

Merged
merged 23 commits into from
Jan 19, 2023
Merged

Merge #255: Refactor frontend and add validation placeholder, support in depth form change #262

merged 23 commits into from
Jan 19, 2023

Conversation

MCatherine1994
Copy link
Contributor

@MCatherine1994 MCatherine1994 commented Jan 18, 2023 •
edited by github-actions bot
Loading

  • added validation placeholder to display error message, support in-depth form field
  • added global state management
  • support form vault change for in-depth repeatable sections, added an example
  • clean up the code, renamed type files
  • fix example page collapse card can't open issue
  • support checking required fields, provide an example
  • support disable fields, provide an example

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@MCatherine1994
fix(fe:FSADT1-539):
69a80c2 
- refactor form section schemas, form initial data, functions into different folders
refs: #89
@MCatherine1994
refactor(fe:FSADT1-539):
22ff2f0 
- refactor the form data and update form value functions to be global states,
refs: #255
@MCatherine1994
refactor(fe:FSADT1-539):
d60cf47 
- refactor some validation function
- update the validation result type
refs: #255
@MCatherine1994
feat/refactor(fe:FSADT1-539):
e16b57e 
- design global state management
- rename type files
- add hardcode validation error display as example
- add hardcode validation error cleanup as example
refs: #255
@MCatherine1994
feat(fe:FSADT1-539)
58afe02 
- refactor the update form value functions
- update the way to display error message, create a error property and computed based on the validation result, compute fieldprops based on the error
- fix add row problem for table/group
refs: #255
@MCatherine1994
Merge branch 'main' of https://github.com/bcgov/nr-forest-client into…
c3886be 
… feat/fe/validation-placeholder

merge(fe:FSADT1-539):
- merge from main
refs: #255
@MCatherine1994
refactor(fe:FSADT1-539):
57330d8 
- improve structure of global state management
refs: #255
@MCatherine1994
fix(fe):
ee52b83 
- fix form example to open next session
@MCatherine1994
feat(fe:FSADT1-539):
20194f6 
- add method to update form data when object depth increase, put as comment for now
refs: #255
@MCatherine1994
feat(fe:FSADT1-539):
bae743f 
- added in depth repeatable sections
- support in depth form value update for in depth repeatble sections
- fix test
refs: #255
@github-actions github-actions bot added configuration changes related to configuration file frontend javascript Pull requests that update Javascript code source source code changes tests test classes changes labels Jan 18, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994
fix(fe:FSADT1-539):
000bcfe 
- remove package installed by accident
refs: #255
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994
feat(fe:FSADT1-539):
4e45328 
- support display error message for in-depth form field
refs: #255
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994 MCatherine1994 marked this pull request as draft January 18, 2023 17:02
@MCatherine1994
feat(fe:FSADT1-539):
5a5185d 
- support customized checking for required fields
refs: #255
@MCatherine1994
feat(fe:FSADT1-539):
c8c7302 
- switch to use string path for form object
- add example to disable a field
refs: #255
@MCatherine1994
test(fe:FSADT1-539):
11c7050 
- add test for new disable and error display feature for form component option file
rfs: #255
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994 MCatherine1994 marked this pull request as ready for review January 19, 2023 00:48
@MCatherine1994
clean(pl):
96cc46b 
- remove unused env vars
refs: #255
@github-actions github-actions bot added backend code related to the java backend application java Pull requests that update Java code openshift labels Jan 19, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

paulushcgcj
paulushcgcj approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@paulushcgcj paulushcgcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for removing the node env from the backend

@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994
clean(fe:FSADT1-539):
96392a2 
- remove unused file
refs: #255
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@MCatherine1994 MCatherine1994 temporarily deployed to dev January 19, 2023 19:21 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev January 19, 2023 19:21 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev January 19, 2023 19:21 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev January 19, 2023 19:21 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 merged commit 46aafef into main Jan 19, 2023
@MCatherine1994 MCatherine1994 deleted the feat/fe/validation-placeholder branch January 19, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulushcgcj paulushcgcj paulushcgcj approved these changes

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@brunoMarchiEncora brunoMarchiEncora Awaiting requested review from brunoMarchiEncora

Assignees
No one assigned
Labels
backend code related to the java backend application configuration changes related to configuration file frontend java Pull requests that update Java code javascript Pull requests that update Javascript code openshift source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCatherine1994 @paulushcgcj @mamartinezmejia