Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data validation #89

Closed
4 tasks done
MCatherine1994 opened this issue Dec 2, 2022 · 0 comments
Closed
4 tasks done

Data validation #89

MCatherine1994 opened this issue Dec 2, 2022 · 0 comments
Labels

Comments

@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Dec 2, 2022

  • only enable for submit button when got all required field
    - create a list for all required fields, specify their container_id, field_id, column_id
    - every time when form data change, check if got all required field, for vue3, could use compute to detect data change
  • call data validation api after submit the form
  • backend provide validation check, and return result to frontend
    - backend could return a list of error messages in the format of
    { [containerId]: Array<{ fieldId: string; columnId?: string; errorMsg: string; }> }
  • display error message in frontend
MCatherine1994 added a commit that referenced this issue Dec 6, 2022
* feat/backend: added api to check duplicate by exact match, refs: #73

* feat/backend: added test for find exact match client api, refs: #73

* Simplified code, made it DRY and reusable, refs: #73

* fix/backend: fix test case function name, refs: #73

* feat/frontend: refactor collapseCard to use composition api, refs: #50

* refactor/frontend: created reusable primary sqaure button, refs: #50

* feat/frontend: added draft json for form structure, added form table component, refs: #50

* feat/frontend: created json schema to generate form structure, refs: #50

* feat/frontend: added form group, refs: #50

* fix/frontend: fix function name and parameters, refs: #50

* feat/frontend: added checkbox, support show/hide field based on another field, refs: #50

* refactor/frontend: refactor the form sections, refs: #50

* feat/frontend: added random index generator for form array, refs: #50

* cleanup/frontend: remove unused print, solve unit test warning, refs: #50

* feat/frontend: fix updateFormArray function name in formTable and formGroup; enabled submit button only when got all required fields, refs: #50

* doc/frontend: add form schema documentation and comment, refs: #50

* doc/frontend: put comment placeholder to data validation check, refs: #89

Co-authored-by: [email protected] <[email protected]>
MCatherine1994 added a commit that referenced this issue Jan 18, 2023
- refactor form section schemas, form initial data, functions into different folders
refs: #89
MCatherine1994 added a commit that referenced this issue Jan 19, 2023
… in depth form change (#262)

* fix(fe:FSADT1-539):
- refactor form section schemas, form initial data, functions into different folders
refs: #89

* refactor(fe:FSADT1-539):
- refactor the form data and update form value functions to be global states,
refs: #255

* refactor(fe:FSADT1-539):
- refactor some validation function
- update the validation result type
refs: #255

* feat/refactor(fe:FSADT1-539):
- design global state management
- rename type files
- add hardcode validation error display as example
- add hardcode validation error cleanup as example
refs: #255

* feat(fe:FSADT1-539)
- refactor the update form value functions
- update the way to display error message, create a error property and computed based on the validation result, compute fieldprops based on the error
- fix add row problem for table/group
refs: #255

* refactor(fe:FSADT1-539):
- improve structure of global state management
refs: #255

* fix(fe):
- fix form example to open next session

* feat(fe:FSADT1-539):
- add method to update form data when object depth increase, put as comment for now
refs: #255

* feat(fe:FSADT1-539):
- added in depth repeatable sections
- support in depth form value update for in depth repeatble sections
- fix test
refs: #255

* fix(fe:FSADT1-539):
- remove package installed by accident
refs: #255

* feat(fe:FSADT1-539):
- support display error message for in-depth form field
refs: #255

* feat(fe:FSADT1-539):
- support customized checking for required fields
refs: #255

* feat(fe:FSADT1-539):
- switch to use string path for form object
- add example to disable a field
refs: #255

* test(fe:FSADT1-539):
- add test for new disable and error display feature for form component option file
rfs: #255

* clean(pl):
- remove unused env vars
refs: #255

* feat(fe:FSADT1-539):
- update form content to the latest
refs: #255

* fix(pl):
- add env to read secrets for pr open
refs: #255

* clean(fe:FSADT1-539):
- remove unused file
refs: #255

Co-authored-by: Maria Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants