-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25863 - Enable Allowable actions after a successful NoW filing #3232
25863 - Enable Allowable actions after a successful NoW filing #3232
Conversation
Signed-off-by: Qin <[email protected]>
After update: "filingTypes": [ |
Signed-off-by: Qin <[email protected]>
|
@@ -980,7 +980,7 @@ def get_incomplete_filings_by_type(business_id: int, filing_type: str): | |||
filings = db.session.query(Filing). \ | |||
filter(Filing.business_id == business_id). \ | |||
filter(Filing._filing_type == filing_type). \ | |||
filter(Filing._status != Filing.Status.COMPLETED.value). \ | |||
filter(not_(Filing._status.in_([Filing.Status.COMPLETED.value, Filing.Status.WITHDRAWN.value]))). \ | |||
order_by(desc(Filing.filing_date)). \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed in the current fix, but update it so the two methods are consistent.
Issue #: /bcgov/entity#25863
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).