-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21929 - get reviews endpoint #2830
Changes from 5 commits
e5e489e
8d0fb08
0fe2593
38c630d
6ca5535
5d95abc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright © 2024 Province of British Columbia | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Tests to assure the reviews end-point. | ||
|
||
Test-Suite to ensure that admin/reviews endpoints are working as expected. | ||
""" | ||
import pytest | ||
from http import HTTPStatus | ||
|
||
from legal_api.services.authz import BASIC_USER, STAFF_ROLE | ||
from tests.unit.services.utils import create_header | ||
|
||
|
||
def test_get_reviews_with_invalid_user(app, session, client, jwt): | ||
"""Assert unauthorized for BASIC_USER role.""" | ||
|
||
rv = client.get(f'/api/v2/admin/reviews', | ||
headers=create_header(jwt, [BASIC_USER], 'user')) | ||
|
||
assert rv.status_code == HTTPStatus.UNAUTHORIZED | ||
|
||
def test_get_reviews_with_valid_user(app, session, client, jwt): | ||
"""Assert review object returned for STAFF role.""" | ||
|
||
rv = client.get(f'/api/v2/admin/reviews', | ||
headers=create_header(jwt, [STAFF_ROLE], 'user')) | ||
|
||
assert rv.status_code == HTTPStatus.OK | ||
assert 'reviews' in rv.json | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add some data to review table to verify this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Working on it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have an initial view of what the future arguments should look like?
|
||
assert 1 == rv.json.get('page') | ||
assert 10 == rv.json.get('limit') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yes, the default sort is oldest first. This is probably worth a comment, but then again, this code will be expanded soon to handle filtering and sorting by different fields.