21929 - get reviews endpoint #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| headers=create_header(jwt, [STAFF_ROLE], 'user')) | ||
|
|
||
| assert rv.status_code == HTTPStatus.OK | ||
| assert 'reviews' in rv.json |
There was a problem hiding this comment.
can you add some data to review table to verify this?
There was a problem hiding this comment.
Working on it
There was a problem hiding this comment.
Do you have an initial view of what the future arguments should look like?
- sorting by different fields
- filtering on different fields
| @classmethod | ||
| def get_paginated_reviews(cls, page, limit): | ||
| """Return paginated reviews.""" | ||
| query = db.session.query(Review).order_by(Review.creation_date.asc()) |
There was a problem hiding this comment.
👍 Yes, the default sort is oldest first. This is probably worth a comment, but then again, this code will be expanded soon to handle filtering and sorting by different fields.
severinbeauvais
approved these changes
Jul 16, 2024
vysakh-menon-aot
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#21929
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).