-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full loader for download business summary #94
Conversation
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-94-ziv1i9va.web.app |
@@ -243,7 +262,7 @@ const contacts = getContactInfo('registries') | |||
</BcrosDialog> | |||
|
|||
<!-- Staff Comments --> | |||
<div v-if="hasRoleStaff && currentBusiness && !isDisableNonBenCorps()"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to disable staff comments for non-Ben corps (that should be managed in COLIN instead)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidently chucked this commit when adding a new one, but I didn't change that line
While testing this, I found a new bug. Try this business (which is actually in Test only). Compare with Filings UI. https://business-dashboard-dev--pr-94-ziv1i9va.web.app/BC1151476 |
*Issue:*bcgov/entity#24518
Description of changes:
Added full screen modal and made it display when downloading business summary and hide when finished. Note that while there does seem to be a downloading flag for the common template, it doesn't appear to be passed through properly so I can't simply set it to true to cause them all to download and there is quite the chain that I'd have to add it to props and pass it through on so I went this way as it's easier
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).