24638 - fix: incorrect name in amalgamation application #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfekete
requested review from
patrickpeinanw,
severinbeauvais and
BrandonSharratt
|
/gcbrun |
| @@ -119,6 +119,7 @@ | |||
| "legalTypes": { | |||
| "CC": "BC Community Contribution Company", | |||
| "BEN": "BC Benefit Company", | |||
| "CBEN": "BC Benefit Company", | |||
There was a problem hiding this comment.
Also need to add CCC and CUL.
There was a problem hiding this comment.
Do you know specific translation that should be added ? Or where I can get them ?
There was a problem hiding this comment.
CCC = same as CC
CUL = same as ULC
|
name is showing as Numbered company, existing problem: |
|
Temporary Url for review: https://business-dashboard-dev--pr-87-qbfm7ysy.web.app SB says, try this: https://business-dashboard-dev--pr-87-qbfm7ysy.web.app/TZHHWYKW5f?accountid=3040 |
severinbeauvais
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:24638 *bcgov/entity#24638
Description of changes:
fix: incorrect name in amalgamation application
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).