Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Issue - Amalgamation Application (Regular) - Dashboard - Mismatch between Current and New #24638

Closed
gunanagar opened this issue Nov 28, 2024 · 6 comments
Assignees
Labels
BTR Business Transparency Register bug Something isn't working Priority1

Comments

@gunanagar
Copy link
Collaborator

Describe the bug in current situation
QA Issue - Amalgamation Application (Regular) - Dashboard - Mismatch between Current and New
Link bug to the User Story

Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low)

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Current Dashboard - https://test.business.bcregistry.gov.bc.ca/TvPz1orwrt?accountid=1999
  4. New Dashboard : https://business-dashboard-test.web.app/TvPz1orwrt?accountid=1999

Naming company in Current dashboard # - SINGING COWBOY ENTERPRISES LTD.
Number Company in New dashboard - Numbered Amalgamated Company

Actual/ observed behavior/ results - New Dashboard

image.png

Expected behavior - Current
image.png

Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

@mstanton1
Copy link
Collaborator

mstanton1 commented Nov 28, 2024

As discussed I've confirmed how the name is determined for the company that results from the amalgamation.

  1. Horizontal Amalgamation / Vertical Amalgamation
  • The name from the first company listed in the amalgamation is used. It doesn't matter if the first company is named or numbered. Note: In this test, I needed to find a company, choose 'Amalgamate' from the more actions menu, and then add other amalgamating businesses. That first company name is shown in the screenshot below as the name that will be used.

image.png

  1. Regular Amalgamation
    A user can choose to adopt the name from an amalgamating business, use a new name request number so they get assigned a new name, or use a newly assigned incorporation number.

image.png

@mstanton1
Copy link
Collaborator

@hfekete @BrandonSharratt @patrickpeinanw I've added images in, and logic, on how the name of the company formed by amalgamation is decided. While doing this, I'm wondering if we should actually need to understand this though. In LEAR, when the amalgamation completes that company should have either a numbered name, or a named name. I imagine there's a field in the DB where the name is stored (probably the same field regardless). As long as we know where to pull the name from in LEAR we should be able to just display that data - and let LEAR figure out which name to populate in that field?

@gunanagar
Copy link
Collaborator Author

gunanagar commented Dec 2, 2024

@hfekete @mstanton1 Retested. Fixed, One more bug Recent Filing history is empty in New dashboard. Can we create as a new bug ?

Current Dashboard:
Screen Shot 2024-12-02 at 10.24.29 AM.png

New Dashboard : - Recent file history is missing
Screen Shot 2024-12-02 at 10.24.08 AM.png

@mstanton1
Copy link
Collaborator

@gunanagar thank you! Is the new bug that the URL is including a temporary number instead of the incorporation number? If so, yes, this would be best as a new bug (it's lower priority so we can log it but not stress about fixing it immediately).

@gunanagar
Copy link
Collaborator Author

As the current issue is fixed, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register bug Something isn't working Priority1
Projects
None yet
Development

No branches or pull requests

3 participants