Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanup in prep for consolidation across projects #4

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Jun 5, 2024

*Issue:*bcgov/entity#21296

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@kialj876 kialj876 self-assigned this Jun 5, 2024
@kialj876
Copy link
Collaborator Author

kialj876 commented Jun 5, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-4-uvkzqxys.web.app

Copy link
Collaborator

@hfekete hfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about app name. If you think this is good for now, its good to merge!

nuxt.config.ts Outdated Show resolved Hide resolved
Signed-off-by: Kial Jinnah <[email protected]>
@kialj876
Copy link
Collaborator Author

kialj876 commented Jun 5, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-4-uvkzqxys.web.app

Signed-off-by: Kial Jinnah <[email protected]>
@kialj876
Copy link
Collaborator Author

kialj876 commented Jun 5, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-4-uvkzqxys.web.app

@kialj876 kialj876 merged commit 6a5817e into bcgov:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants