-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24656 - Handle NoW Draft in ToDoList #118
Merged
severinbeauvais
merged 8 commits into
bcgov:main
from
ArwenQin:24656-Support-NoW-ToDoList
Jan 14, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3039ca5
handle NoW draft in ToDoList
ArwenQin 90386de
change comments and function name
ArwenQin 54c4f59
try to update enum dependency
ArwenQin 0472b44
try to update enum dependency 2
ArwenQin 2fc6a91
reverse lock file change
ArwenQin ec2e3aa
try to update dependency 3
ArwenQin 57d51f7
revert lock file
ArwenQin 33edce7
update version
ArwenQin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,13 +5,13 @@ import { FilingTypes } from '@bcrs-shared-components/enums' | |
/** Files a new filing (todo item). */ | ||
export const doFileNow = (item: TodoItemI) => { | ||
const business = useBcrosBusiness() | ||
const { goToBusinessDashboard, goToEditPage } = useBcrosNavigate() | ||
const { goToFilingUI, goToEditPage } = useBcrosNavigate() | ||
switch (item.name) { | ||
case FilingTypes.ANNUAL_REPORT: { | ||
// file the subject Annual Report | ||
const path = `/${business.currentBusiness.identifier}/annual-report` | ||
const param = { filingId: '0', arFilingYear: item.ARFilingYear.toString() } | ||
goToBusinessDashboard(path, param) | ||
goToFilingUI(path, param) | ||
break | ||
} | ||
case FilingTypes.CONVERSION: { | ||
|
@@ -41,7 +41,7 @@ export const doResumePayment = (item: TodoItemI): boolean => { | |
export const doResumeFiling = (item: TodoItemI): void => { | ||
const { currentBusinessIdentifier } = useBcrosBusiness() | ||
const { bootstrapIdentifier } = useBcrosBusinessBootstrap() | ||
const { goToBusinessDashboard, goToCreatePage, goToEditPage } = useBcrosNavigate() | ||
const { goToFilingUI, goToCreatePage, goToEditPage } = useBcrosNavigate() | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! (PS The dashboard code will be removed from Filings UI in the near future, so it will truly be only a filings UI.) |
||
let navigateFn: Function | undefined | ||
let path = '' | ||
|
@@ -55,29 +55,29 @@ export const doResumeFiling = (item: TodoItemI): void => { | |
break | ||
|
||
case FilingTypes.ANNUAL_REPORT: | ||
// navigate to the Annual Report page of the old dashboard | ||
navigateFn = goToBusinessDashboard | ||
// navigate to the Annual Report page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/annual-report` | ||
params = { filingId: item.filingId.toString(), arFilingYear: item.ARFilingYear.toString() } | ||
break | ||
|
||
case FilingTypes.CHANGE_OF_DIRECTORS: | ||
// navigate to Change of Directors page of the old dashboard | ||
navigateFn = goToBusinessDashboard | ||
// navigate to Change of Directors page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/standalone-directors` | ||
params = { filingId: item.filingId.toString() } | ||
break | ||
|
||
case FilingTypes.CHANGE_OF_ADDRESS: | ||
// navigate to Change of Address page of the old dashboard | ||
navigateFn = goToBusinessDashboard | ||
// navigate to Change of Address page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/standalone-addresses` | ||
params = { filingId: item.filingId.toString() } | ||
break | ||
|
||
case FilingTypes.CONSENT_CONTINUATION_OUT: | ||
// navigate to Consent Continuation Out page of the old dashboard | ||
navigateFn = goToBusinessDashboard | ||
// navigate to Consent Continuation Out page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/consent-continuation-out` | ||
params = { filingId: item.filingId.toString() } | ||
break | ||
|
@@ -90,8 +90,8 @@ export const doResumeFiling = (item: TodoItemI): void => { | |
break | ||
|
||
case FilingTypes.CONTINUATION_OUT: | ||
// navigate to Continuation Out page of the old dashboard | ||
navigateFn = goToBusinessDashboard | ||
// navigate to Continuation Out page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/continuation-out` | ||
params = { filingId: item.filingId.toString() } | ||
break | ||
|
@@ -145,6 +145,16 @@ export const doResumeFiling = (item: TodoItemI): void => { | |
params = { 'conversion-id': item.filingId.toString() } | ||
break | ||
|
||
case FilingTypes.NOTICE_OF_WITHDRAWAL: | ||
// navigate to Notice of Withdrawal page of Filings UI | ||
navigateFn = goToFilingUI | ||
path = `/${currentBusinessIdentifier}/notice-of-withdrawal` | ||
params = { | ||
filingToBeWithdrawn: item.filingToBeWithdrawn.toString(), | ||
filingId: item.filingId.toString() | ||
} | ||
break | ||
|
||
case FilingTypes.SPECIAL_RESOLUTION: | ||
// navigate to Edit UI to resume this Special Resolution | ||
navigateFn = goToEditPage | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename it to Filing URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.