24656 - Handle NoW Draft in ToDoList #118

ArwenQin · 2025-01-13T19:07:25Z

Description of changes:

Handle NoW Draft in ToDoList (Dashboard)
Can resume and delete now

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Qin <[email protected]>

severinbeauvais · 2025-01-13T19:47:22Z

/gcbrun

bcregistry-sre · 2025-01-13T19:49:36Z

Temporary Url for review: https://business-dashboard-dev--pr-118-9dk5tahd.web.app

src/utils/todo/action-functions.ts

src/utils/todo/task-filing/index.ts

ArwenQin · 2025-01-13T19:57:11Z

test:
https://business-dashboard-dev--pr-118-9dk5tahd.web.app/BC0886180

ArwenQin · 2025-01-13T19:57:51Z

Signed-off-by: Qin <[email protected]>

ArwenQin · 2025-01-13T21:09:13Z

.env.example

@@ -10,8 +10,7 @@ VUE_APP_BUSINESSES_URL="https://dev.account.bcregistry.gov.bc.ca/"
 VUE_APP_BCONLINE_URL="https://d1.bconline.gov.bc.ca/"
 VUE_APP_BUSINESS_EDIT_URL="https://dev.edit.business.bcregistry.gov.bc.ca"
 VUE_APP_BUSINESS_CREATE_URL="https://dev.create.business.bcregistry.gov.bc.ca"
-# old dashboard
-VUE_APP_DASHBOARD_URL="https://dev.business.bcregistry.gov.bc.ca/"
+VUE_APP_BUSINESS_FILING_URL="https://dev.business.bcregistry.gov.bc.ca/"



Rename it to Filing URL

I like this.

ArwenQin · 2025-01-13T21:09:48Z

package.json

@@ -19,7 +19,7 @@
  },
  "dependencies": {
    "@bcrs-shared-components/corp-type-module": "^1.0.16",
-    "@bcrs-shared-components/enums": "^1.1.12",
+    "@bcrs-shared-components/enums": "1.1.18",
    "@bcrs-shared-components/interfaces": "^1.1.16",


try to update the enum dependency, try to test if it fixes the filing type error

Did you run pnpm i after this?

You may need to commit the lock file, too.

Thank you! Just committed the lock file

This looks good, and so does the lock file. ~~Resolving.~~

@patrickpeinanw Can we keep this change and the lock file change? I assume the unit tests will be OK with just an update to the enums shared package.

ArwenQin · 2025-01-13T21:11:32Z

src/utils/todo/action-functions.ts

@@ -41,7 +41,7 @@ export const doResumePayment = (item: TodoItemI): boolean => {
 export const doResumeFiling = (item: TodoItemI): void => {
  const { currentBusinessIdentifier } = useBcrosBusiness()
  const { bootstrapIdentifier } = useBcrosBusinessBootstrap()
-  const { goToBusinessDashboard, goToCreatePage, goToEditPage } = useBcrosNavigate()
+  const { goToFilingUI, goToCreatePage, goToEditPage } = useBcrosNavigate()



Thanks!

(PS The dashboard code will be removed from Filings UI in the near future, so it will truly be only a filings UI.)

severinbeauvais · 2025-01-13T21:47:26Z

/gcbrun

Signed-off-by: Qin <[email protected]>

JazzarKarim · 2025-01-13T23:03:40Z

/gcbrun

bcregistry-sre · 2025-01-13T23:05:50Z

Temporary Url for review: https://business-dashboard-dev--pr-118-9dk5tahd.web.app

ArwenQin · 2025-01-13T23:08:07Z

updated the enum dependency, now working:
test:
https://business-dashboard-dev--pr-118-9dk5tahd.web.app/BC0886180

pnpm-lock.yaml

severinbeauvais · 2025-01-13T23:19:57Z

I see some failed checks. (In the previous PR, these checks passed.) This may be related to the lockfile issue 🤷‍♂️

Signed-off-by: Qin <[email protected]>

ArwenQin · 2025-01-14T18:18:16Z

Tried to manually update the enum dependency version, but the checks failed again.

@severinbeauvais I will revert back to the old dependencies, like Patrick said

Is it ok to leave the enum dependency change now? Then the Resume will not work, until we update it.

Signed-off-by: Qin <[email protected]>

ArwenQin · 2025-01-14T18:38:25Z

@patrickpeinanw Reverting the lock file back, all checks passed in my previous commit, but now it failed again. Do you know why or could you please re-run the failed test?

meawong · 2025-01-14T18:46:35Z

/gcbrun

bcregistry-sre · 2025-01-14T18:49:15Z

Temporary Url for review: https://business-dashboard-dev--pr-118-9dk5tahd.web.app

severinbeauvais

I don't know who's going to merge first, but please update the app version.

ArwenQin · 2025-01-14T18:53:22Z

I don't know who's going to merge first, but please update the app version.

Sure. Shall I update the enum version in package file and manually do it in lock file like this:

@severinbeauvais

severinbeauvais · 2025-01-14T18:53:52Z

Is it ok to leave the enum dependency change now? Then the Resume will not work, until we update it.

My hope is that Patrick approves the enum update and package lock change.

Arwen, you had one commit where you updated the enum and lock file. Did the unit tests pass?

severinbeauvais · 2025-01-14T18:54:41Z

Sure. Shall I update the enum version in package file and manually do it in lock file like this:

It depends on Patrick's expert opinion. It also depends on whether the unit tests pass with this change.

ArwenQin · 2025-01-14T18:55:43Z

Sure. Shall I update the enum version in package file and manually do it in lock file like this:

It depends on Patrick's expert opinion. It also depends on whether the unit tests pass with this change.

No, all tests failed when updating the package and lock file

severinbeauvais · 2025-01-14T18:57:59Z

No, all tests failed when updating the package and lock file

Darn.

Well, do you want to update the unit tests in this PR or another one?

ArwenQin · 2025-01-14T19:04:58Z

No, all tests failed when updating the package and lock file

Darn.

Well, do you want to update the unit tests in this PR or another one?

Just tried, seems not easy, better in a new PR

Signed-off-by: Qin <[email protected]>

severinbeauvais · 2025-01-14T19:43:00Z

Well, do you want to update the unit tests in this PR or another one?

Just tried, seems not easy, better in a new PR

OK, let's do that. I'll approve this PR in a minute. Try to get an approval from Patrick as well.

patrickpeinanw

Looks good to me! Thank you for updating the naming for Filing UI. goToBusinessDashboard and dashboardOldUrl were confusing.

Feel free to update the dependency version if needed. I am Ok with doing it either here or in another PR.

Re the failing cypress test, such failure occurs sometimes, and it is not always the same one. Re-running the test would usually remove the error but this time we got no luck. It is a tech debt that has been bugging us for a long time.

ArwenQin · 2025-01-14T20:09:37Z

@severinbeauvais could you please merge it? I don't have admin right.
I will create a new ticket to update the enum dependency and fix unit tests.
Thank you!

JazzarKarim

👍 👍

handle NoW draft in ToDoList

3039ca5

Signed-off-by: Qin <[email protected]>

ArwenQin requested review from hfekete, patrickpeinanw, severinbeauvais, JazzarKarim, Rajandeep98 and ketaki-deodhar as code owners January 13, 2025 19:07

severinbeauvais assigned ArwenQin Jan 13, 2025

severinbeauvais reviewed Jan 13, 2025

View reviewed changes

src/utils/todo/action-functions.ts Outdated Show resolved Hide resolved

severinbeauvais reviewed Jan 13, 2025

View reviewed changes

src/utils/todo/task-filing/index.ts Show resolved Hide resolved

ArwenQin added 2 commits January 13, 2025 13:06

change comments and function name

90386de

Signed-off-by: Qin <[email protected]>

try to update enum dependency

54c4f59

Signed-off-by: Qin <[email protected]>

ArwenQin commented Jan 13, 2025

View reviewed changes

try to update enum dependency 2

0472b44

Signed-off-by: Qin <[email protected]>

severinbeauvais reviewed Jan 13, 2025

View reviewed changes

pnpm-lock.yaml Outdated Show resolved Hide resolved

reverse lock file change

2fc6a91

Signed-off-by: Qin <[email protected]>

patrickpeinanw mentioned this pull request Jan 14, 2025

24659 - Implement Withdraw Action in Ledger #119

Merged

try to update dependency 3

ec2e3aa

Signed-off-by: Qin <[email protected]>

revert lock file

57d51f7

Signed-off-by: Qin <[email protected]>

severinbeauvais reviewed Jan 14, 2025

View reviewed changes

update version

33edce7

Signed-off-by: Qin <[email protected]>

severinbeauvais approved these changes Jan 14, 2025

View reviewed changes

patrickpeinanw approved these changes Jan 14, 2025

View reviewed changes

JazzarKarim approved these changes Jan 14, 2025

View reviewed changes

severinbeauvais merged commit c5ecd47 into bcgov:main Jan 14, 2025
4 of 6 checks passed

24656 - Handle NoW Draft in ToDoList #118

24656 - Handle NoW Draft in ToDoList #118

Conversation

ArwenQin commented Jan 13, 2025

severinbeauvais commented Jan 13, 2025

bcregistry-sre commented Jan 13, 2025

ArwenQin commented Jan 13, 2025

ArwenQin commented Jan 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais commented Jan 13, 2025

JazzarKarim commented Jan 13, 2025

bcregistry-sre commented Jan 13, 2025

ArwenQin commented Jan 13, 2025

severinbeauvais commented Jan 13, 2025

ArwenQin commented Jan 14, 2025 • edited Loading

ArwenQin commented Jan 14, 2025

meawong commented Jan 14, 2025

bcregistry-sre commented Jan 14, 2025

severinbeauvais left a comment

Choose a reason for hiding this comment

ArwenQin commented Jan 14, 2025 • edited Loading

severinbeauvais commented Jan 14, 2025

severinbeauvais commented Jan 14, 2025

ArwenQin commented Jan 14, 2025

severinbeauvais commented Jan 14, 2025

ArwenQin commented Jan 14, 2025

severinbeauvais commented Jan 14, 2025

patrickpeinanw left a comment

Choose a reason for hiding this comment

ArwenQin commented Jan 14, 2025

JazzarKarim left a comment

Choose a reason for hiding this comment

severinbeauvais Jan 14, 2025 •

edited

Loading

ArwenQin commented Jan 14, 2025 •

edited

Loading

ArwenQin commented Jan 14, 2025 •

edited

Loading