Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sc3171 #142

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Sc3171 #142

merged 4 commits into from
Nov 1, 2023

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Oct 27, 2023 •
edited
Loading

Description

  • Provides clear button (X) inside the search input box
  • Include Tooltips to every icon button including clear button
  • Corrections to Aria-label specifically to syn and detail buttons
  • Make sure search clear button can be navigated using tab and consistent with focus change

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 72.73% ( 56 / 77 )
Methods: 62.5% ( 5 / 8 )
Lines: 86% ( 43 / 50 )
Branches: 42.11% ( 8 / 19 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 35.99% ( 623 / 1731 )
Methods: 34.64% ( 133 / 384 )
Lines: 43.22% ( 437 / 1011 )
Branches: 15.77% ( 53 / 336 )

@jatindersingh93 jatindersingh93 marked this pull request as ready for review October 31, 2023 18:25
TimCsaky
TimCsaky approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

frontend/src/components/object/ObjectTable.vue Outdated Show resolved Hide resolved
frontend/src/components/object/ObjectTable.vue Show resolved Hide resolved
jujaga
jujaga approved these changes Nov 1, 2023
View reviewed changes
frontend/src/components/object/ObjectTable.vue Outdated Show resolved Hide resolved
@jujaga jujaga merged commit 6f20a26 into master Nov 1, 2023
14 checks passed
@jujaga jujaga deleted the SC3171 branch November 1, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle1morel kyle1morel kyle1morel approved these changes

@TimCsaky TimCsaky TimCsaky approved these changes

@jujaga jujaga jujaga approved these changes

@wilwong89 wilwong89 Awaiting requested review from wilwong89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jatindersingh93 @jujaga @TimCsaky @kyle1morel