Applied review suggestions

bcgov · Nov 1, 2023 · 860bb72 · 860bb72
1 parent 01652e5
commit 860bb72
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/frontend/src/assets/main.scss b/frontend/src/assets/main.scss
@@ -183,5 +183,4 @@ td .wrap-block {
 .p-input-icon-clear-right {
   position: absolute !important;
   right: 0rem;
-  line-height: 1.2;
 }
diff --git a/frontend/src/components/object/ObjectFileDetails.vue b/frontend/src/components/object/ObjectFileDetails.vue
@@ -165,9 +165,9 @@ watch([props, getObjects], async () => {
           />
           <Button
             v-if="permissionStore.isObjectActionAllowed(props.objectId, getUserId, Permissions.MANAGE, bucketId)"
-            v-tooltip.bottom="'Bucket permissions'"
+            v-tooltip.bottom="'Object permissions'"
             class="p-button-lg p-button-text"
-            aria-label="Bucket permissions"
+            aria-label="Object permissions"
             @click="showPermissions(props.objectId)"
           >
             <font-awesome-icon icon="fa-solid fa-users" />

diff --git a/frontend/src/components/object/ObjectTable.vue b/frontend/src/components/object/ObjectTable.vue
@@ -125,10 +125,11 @@ const filters = ref({
             <i class="pi pi-search" />
             <InputText
               v-model="filters['global'].value"
+              class="searchInput"
               placeholder="Search File Names"
             />
             <Button
-              v-show="filters['global'].value != null"
+              v-show="filters['global'].value !== null"
               v-tooltip.bottom="'Clear'"
               class="ml-2 p-input-icon-clear-right"
               icon="pi pi-times"
@@ -251,9 +252,9 @@ const filters = ref({
               data.public ||
               permissionStore.isObjectActionAllowed(data.id, getUserId, Permissions.READ, props.bucketId as string)
             "
-            v-tooltip.bottom="'Bucket detail'"
+            v-tooltip.bottom="'Object details'"
             class="p-button-lg p-button-rounded p-button-text"
-            aria-label="Bucket detail"
+            aria-label="Object details"
             @click="showInfo(data.id)"
           >
             <font-awesome-icon icon="fa-solid fa-circle-info" />
@@ -295,7 +296,7 @@ const filters = ref({
   </div>
 </template>
 <style lang="scss" scoped>
-:deep(.p-inputtext) {
+:deep(.searchInput.p-inputtext) {
   padding-right: 2.5rem;
 }
 </style>