Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result対応と技能のマイナス対応 #504

Merged
merged 6 commits into from
Oct 16, 2021
Merged

Result対応と技能のマイナス対応 #504

merged 6 commits into from
Oct 16, 2021

Conversation

FredGreenfield
Copy link
Contributor

・Result対応
 難易度が指定されているときのみ対応。難易度が指定されていない場合は成功/失敗の区別がつかないため文字列を返す。
・機能強化
 技能がマイナスになった時の処理を受け付けるように修正。

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #504 (ce7285c) into master (a3e2827) will increase coverage by 0.08%.
The diff coverage is 98.94%.

❗ Current head ce7285c differs from pull request most recent head 8b7f2a4. Consider uploading reports for the commit 8b7f2a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   95.35%   95.43%   +0.08%     
==========================================
  Files         291      310      +19     
  Lines       18728    18247     -481     
==========================================
- Hits        17858    17414     -444     
+ Misses        870      833      -37     
Impacted Files Coverage Δ
lib/bcdice/game_system/BeginningIdol.rb 100.00% <ø> (+0.36%) ⬆️
lib/bcdice/game_system/BeginningIdol_Korean.rb 100.00% <ø> (+0.37%) ⬆️
lib/bcdice/game_system/SteamPunkers.rb 95.12% <ø> (ø)
lib/bcdice/dice_table/d66_table.rb 91.30% <33.33%> (-8.70%) ⬇️
...b/bcdice/game_system/beginning_idol/chain_table.rb 94.44% <94.44%> (ø)
...ib/bcdice/game_system/beginning_idol/work_table.rb 96.87% <96.87%> (ø)
lib/bcdice/game_system/PersonaO.rb 97.29% <97.29%> (ø)
lib/bcdice/game_system/ToshiakiHolyGrailWar.rb 97.56% <97.56%> (ø)
...ice/game_system/beginning_idol/with_abnormality.rb 97.67% <97.67%> (ø)
lib/bcdice/base.rb 95.74% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e2827...8b7f2a4. Read the comment docs.

@ysakasin ysakasin self-requested a review October 5, 2021 02:43
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ysakasin ysakasin merged commit dea3c9c into bcdice:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants