SW2.5のモンストラスロアで追加された森羅魔法のダメージ算出ダイスに対応 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 94.47% 94.47% -0.01%
==========================================
Files 272 272
Lines 18491 18506 +15
==========================================
+ Hits 17470 17484 +14
- Misses 1021 1022 +1
Continue to review full report at Codecov.
|
ysakasin
requested changes
Jan 28, 2021
|
出力ですが、以下のようにコマンドがわかるようにした方が良いと思うのですがどうでしょう。 また、入力が |
ysakasin
requested changes
Feb 10, 2021
| case command | ||
| when DRUID_DICE_RE | ||
| power_list = Regexp.last_match.captures.map(&:to_i) | ||
| druid_parser = Command::Parser.new(DRUID_DICE_RE, round_type: BCDice::RoundType::CEIL) |
There was a problem hiding this comment.
Command::Parserに渡す正規表現で ^ を使うのは想定していないため、使いまわさずにリテラルで指定してください。
|
|
||
| def eval_game_system_specific_command(command) | ||
| case command | ||
| when DRUID_DICE_RE |
There was a problem hiding this comment.
Command::Parser で使いまわさないため、定数で使いまわさずにリテラルを直接指定してください
|
ご連絡遅くなり申し訳ありません。レビュー部分反映させていただきました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SW2.5のモンストラスロアで追加されたドルイド技能（森羅魔法）において、
一部魔法で特異なダメージ算出方法が追加されました。
威力決定の際に威力表を参照せず、2d6の出目の範囲に応じて
という形でダメージを算出しています。このA、B、Cの値は、使用する魔法によって異なっています。
「ダメージ算出」であるという性質上加減算などが必要になり、 単純なダイス表で表現するのも難しいため、専用のダイスコマンドを実装いたしました。