Expand modified_by and created_by metadata

[j616]

Details

This PR:

• Adds a modified_by parameter to flow resources
• Adds a created_by parameter to flow delete request resources

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186711248

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

• Added bbc/rd-apmm-cloudfit team as a reviewer
• PR completes task/fixes bug
• Tests exercise code appropriately
• New features and API breaks are flagged in commit messages using magic strings
• Repo maintainer is notified that a release is required
• Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
• Downstream repos have been checked for potential breaks & fixed as needed
• APIs/UIs/CLIs updated as required
• PR added to Pivotal story
• Follow-up stories added to Pivotal
• Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
• Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

• PR completes task/fixes bug
• Tests exercise code appropriately
• Design makes sense, and fits with our current code base
• Code is easy to follow
• PR size is sensible
• Commit history is sensible and tidy

Info on Cloudfit PRs

• The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.
• For more details on how to asses PRs, see: https://github.com/bbc/rd-apmm-docs-ways-of-working/blob/master/workflow/PRChecklist.md

[philipnbbc]

LGTM

[j616]

Requesting re-review for added ADR

[philipnbbc]

ADR LGTM. I assume you'll add a commit to change the ADR status to "accepted"? Does it make sense to just start it off at "accepted" in this PR as the ADR and solution are bundled together?

[j616]

@philipnbbc The ADR README describes the process. TL;DR: The discussion/modification happens in the PR. The ADR status is then updated just before the PR merges. The ADR could be rejected but still merged as capturing why we didn't do something can be as important as capturing why we did do something.

[samdbmg]

LGTM, including use of ADR template