Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI linting for Markdown files #16

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Jan 12, 2024

Details

Adds linting of Markdown files in the repository using https://github.com/DavidAnson/markdownlint-cli2

Might make it a bit easier to keep the docs neat (and it found a misnumbering for me!). Thoughts?

Pivotal Story

Story URL: Done as part of https://www.pivotaltracker.com/story/show/186644493

Related PRs

Follows #15

Links to external test runs/working deployment

N/A

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@samdbmg samdbmg requested a review from a team January 12, 2024 14:27
@samdbmg samdbmg marked this pull request as ready for review January 12, 2024 14:27
@robwadge robwadge self-assigned this Jan 15, 2024
Copy link
Contributor

@robwadge robwadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good idea to add linting checks

@samdbmg samdbmg force-pushed the sammg-markdown-linting branch 4 times, most recently from 40cf273 to f0e7c8d Compare January 15, 2024 14:39
@samdbmg samdbmg requested a review from robwadge January 15, 2024 14:39
@samdbmg
Copy link
Member Author

samdbmg commented Jan 15, 2024

I've made some fairly substantial changes to how this works (moving from an Action to a Docker image) so I can use the custom one-sentence-per-line rule - requesting re-review as a result

@samdbmg samdbmg force-pushed the sammg-markdown-linting branch from f0e7c8d to 5ba643e Compare January 15, 2024 14:41
Add ADR folder structure and templates
@samdbmg samdbmg force-pushed the sammg-markdown-linting branch 2 times, most recently from 9086d6b to 39f367f Compare January 16, 2024 13:49
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci-workflow.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@robwadge robwadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to linting LGTM

Adds linting using markdown lint for ADRs and the README
@samdbmg samdbmg force-pushed the sammg-markdown-linting branch from bbc1236 to 48a9f03 Compare January 17, 2024 16:34
@samdbmg samdbmg merged commit 61053d2 into sammg-add-adr-process Jan 18, 2024
3 checks passed
@samdbmg samdbmg deleted the sammg-markdown-linting branch January 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants