-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR folder structure and templates #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdbmg
force-pushed
the
sammg-add-adr-process
branch
from
January 12, 2024 14:18
424f849
to
bf31c13
Compare
samdbmg
commented
Jan 12, 2024
Adds a description of how to create ADR documents, and how they should be managed and merged.
Removes some of the steps that either don't make sense for this repo, or only make sense internally.
samdbmg
force-pushed
the
sammg-add-adr-process
branch
from
January 12, 2024 14:24
bf31c13
to
5a5622a
Compare
18 tasks
AndrewGibb
suggested changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to resolve
Co-authored-by: Andrew Gibb <[email protected]>
Co-authored-by: Andrew Gibb <[email protected]>
Replaces the "force" and "facing concern" terms with the clearer "requirement" Adds some wording about facilitating the review process.
AndrewGibb
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Extends and supersedes #14 by adding documentation on how to run the ADR process. Also amends the PR template to make more sense in this repo.
Pivotal Story
Story URL: https://www.pivotaltracker.com/story/show/186644493
Related PRs
Supersedes #14
Links to external test runs/working deployment
N/A
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on Cloudfit PRs