Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #5234 from bbc/navigation-and-skip-link" #5386

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

tochwill
Copy link
Contributor

@tochwill tochwill commented Feb 4, 2020

This reverts commit e685035, reversing
changes made to e93de56.

Resolves #NUMBER

Overall change:
A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

This reverts commit e685035, reversing
changes made to e93de56.
@tochwill tochwill self-assigned this Feb 4, 2020
@amywalkerdev amywalkerdev merged commit da70e7a into latest Feb 4, 2020
@amywalkerdev amywalkerdev deleted the revert-navigation branch February 4, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants