-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Navigation and move Skip Link to Brand #5234
Conversation
…o integrate-new-navigation
…o integrate-new-navigation
Blocked by ios testing. |
Seeing a couple of issues on Opera Mini extreme mode (also seeing some live issues on Opera Mini) - having a chat about this today |
@tochwill Have tested on ios using the heroku app url looks good but i am seeing the page content blocked in opera mini in extreme mode looks good in data savings high and off mode. Also voice over on ios looks good.All good from testing perspective except opera mini issue. |
@PriyaKR have spoken to Jim and Neil about Opera Mini issues, they'd like to go ahead with releasing and create new issues to fix Opera Mini issues this week. |
Just need to update bundle size config |
Fixing failing tests... |
Revert "Merge pull request #5234 from bbc/navigation-and-skip-link"
…-link"" This reverts commit dd72e88.
Resolves #4571
Overall change:
This PR implements the following:
Integrate Psammead components and handle state for AMP and Canonical. (#4571 and #4570)
Add entry and exit animation for navigation dropdown, for AMP and Canonical. (#4579)
Move skip to content link from navigation to brand component (#2829)
Code changes:
Testing:
The expected behaviour for this PR is as follows:
For all page types - the navigation remains as it currently behaves on live for screen widths > 599px.
For screen widths below 599px and below, for all page types:
Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)This PR requires manual testing