This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add prop to allow us to set aria-hidden on live label #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tochwill
commented
Mar 4, 2020
sareh
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Looks good. We will look at pulling out LiveLabel into its own Psammead component in another PR: #3203
Note for testing: since Storybook is running on the client only, this fix won't seem necessary, until the component is pulled into an application that is server-rendered.
DenisHdz
reviewed
Mar 4, 2020
| @@ -227,7 +227,9 @@ export const Link = styled.a` | |||
| } | |||
| `; | |||
|
|
|||
| export const LiveLabel = styled.span` | |||
| export const LiveLabel = styled.span.attrs( | |||
| props => props.ariaHidden && { 'aria-hidden': 'true' }, | |||
There was a problem hiding this comment.
Suggested change
| props => props.ariaHidden && { 'aria-hidden': 'true' }, | |
| ${({ ariaHidden }) => ariaHidden && { 'aria-hidden': 'true' }}, |
…o update-live-aria-hidden
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves bbc/simorgh#5749
Overall change:
Styled components strips out 'aria-hidden' when rendering on the server. Will look into this, but in the meantime we can pass a prop to the live label that lets us set this attribute.
Code changes: