Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Turkish & Vietnamese translation for Live label #5749

Closed
1 task done
sareh opened this issue Mar 3, 2020 · 0 comments · Fixed by #5756, BBC-archive/psammead#3206 or BBC-archive/psammead#3208
Closed
1 task done
Assignees

Comments

@sareh
Copy link
Contributor

sareh commented Mar 3, 2020

Is your feature request related to a problem? Please describe.
Use CANLI instead of LIVE for turkish live label.
Use TRỰC TIẾP instead of LIVE for vietnamese live label.
Use لائیو instead of LIVE for urdu live label.

Describe the solution you'd like
Translation is already in the Simorgh codebase. We should ensure the Live Label is using this translation in the Story Promo:

https://github.com/bbc/simorgh/blob/latest/src/app/containers/StoryPromo/index.jsx#L83-L86

We should ensure the VisuallyHiddenText lang="en-GB" element is not added if text is not in English.

We should also check that the live label is added in all relevant places, e.g. Bulletins (Radio/TV), Radio schedules.

  • In Bulletins, the Live label will always be aria-hidden, with visually hidden text that reads 'Watch Live,', with watch translated into the correct language. This will be updated to contain a fully translated string in another issue.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes

Dev insight: Unit tests/snapshots should be sufficient. Adding screenshots of the changes made to the PR would be great.

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Mar 3, 2020
@sareh sareh changed the title Update Turkish Live label Show Turkish translation for Live label Mar 3, 2020
@sareh sareh changed the title Show Turkish translation for Live label Show Turkish & Vietnamese translation for Live label Mar 3, 2020
@tochwill tochwill self-assigned this Mar 3, 2020
@tochwill tochwill reopened this Mar 4, 2020
@tochwill tochwill reopened this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment