Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create Live Label component #3203

Closed
1 task done
sareh opened this issue Mar 4, 2020 · 0 comments · Fixed by #3224
Closed
1 task done

Create Live Label component #3203

sareh opened this issue Mar 4, 2020 · 0 comments · Fixed by #3224
Assignees
Labels
live-label ws-home Tasks for the WS Home Team

Comments

@sareh
Copy link
Contributor

sareh commented Mar 4, 2020

Is your feature request related to a problem? Please describe.
We currently use Live labels with the associated visually hidden text and aria hidden attribute in three different places in our code base. This leads to updates to usage needing to be made in multiple places - story promo, bulletin promo and usage within the parent application.
E.g. See all of the PRs linked to this issue: bbc/simorgh#5749

We should have a single reusable component that handles all of this logic and can be used in various contexts.

Describe the solution you'd like
It should be a self-contained package that can be used on pages in English as well as those not in English. Passing in translation when needed and applying relevant aria roles if necessary.

Describe alternatives you've considered
We could choose to keep it as it currently is, with implementation duplicated in multiple places.

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Mar 4, 2020
@sareh sareh changed the title Relate Psammead Live Label Create Psammead Live Label Mar 4, 2020
@DenisHdz DenisHdz self-assigned this Mar 5, 2020
@DenisHdz DenisHdz removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Mar 5, 2020
@DenisHdz DenisHdz changed the title Create Psammead Live Label Create Live Label component Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
live-label ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants