file-truename when caching current file. Closes #667

[colonelpanic8]

No description provided.

[bbatsov]

Change to commit message to "[Fix #667] Use file-truename ...".

[bbatsov]

Mention the bugfix in the changelog and remove the . from the commit message (commit message titles are not sentences).

[bbatsov]

This should be in the Bugs fixed section of the master.

[colonelpanic8]

Okay, so really, what you mean is that this needs to be merged with master...

[bbatsov]

Yes.

On Saturday, April 25, 2015, IvanMalison [email protected] wrote:

In CHANGELOG.md
#691 (comment):

@@ -30,6 +30,9 @@ to behave like helm-find-files, such as multifile selection and opening or del
buffers by name

• New defcustom projectile-globally-ignored-file-suffixes allows
  you to globally ignore files with particular extensions
  +* Use file-truename when caching filenames to prevent

Okay, so really, what you mean is that this needs to be merged with
master...

—
Reply to this email directly or view it on GitHub
https://github.com/bbatsov/projectile/pull/691/files#r29098818.

Best Regards,
Bozhidar Batsov

http://www.batsov.com

[bbatsov]

The place of this entry has to be updated.

[colonelpanic8]

What? Is it not currently in the right place?

[bbatsov]

0.12 was already released. See the latest version of the changelog and you'll understand what I mean.

[bbatsov]

@IvanMalison ping

[colonelpanic8]

I can take a look at this soon

[bbatsov]

//cc @vspinu

[vspinu]

I think this patch indeed fixes a bug. As project root's name is always true name. Ths all files expanded against it should be truename as well. Also the defadvice on delete-file uses a similar logic to projectile-cache-current-file and it already calls file-truename.

This function is not critical in any sense. It's called either interactively or from the file-find-hook and only when projectile-enable-caching is on, which it's nil by default.

[vspinu]

Could you please move these last two bindings inside the following (when. There is no point for them unless that conditional is true.

Also remove the double call to projectile-project-root on this occasion.

[colonelpanic8]

status?

[bbatsov]

👍

[vspinu]

In that case, the truename is horrendous

That's a relative name, not true name. From what you have said, I don't understand what's the exact problem nor how the new behavior "is a bug".

[kini]

FWIW, even if you made that an absolute path, it would look like /foo/bar/sos_cache/prj_name/prj_name_sos_cache/prj_name/FILES/dir1#dir1_1#dir1_1_1#file_name_v_1.23_456789, which is still horrendous :)