-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinks pointing to directories inside a projectile project are added to projectile files cache #667
Comments
This actually seems to happen even with files that are not ignored. I'm not sure why I thought it only happens with files that ignored. @bbatsov Do you have an opinion about what should be happening here? |
colonelpanic8
added a commit
to colonelpanic8/projectile
that referenced
this issue
Mar 22, 2015
colonelpanic8
added a commit
to colonelpanic8/projectile
that referenced
this issue
Mar 31, 2015
colonelpanic8
added a commit
to colonelpanic8/projectile
that referenced
this issue
Mar 31, 2015
colonelpanic8
added a commit
to colonelpanic8/projectile
that referenced
this issue
Apr 8, 2015
colonelpanic8
added a commit
to colonelpanic8/projectile
that referenced
this issue
Apr 9, 2015
bbatsov
added a commit
that referenced
this issue
Jun 19, 2015
file-truename when caching current file. Closes #667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sorry for the obscure/confusing title. I'm finding it difficult to accurately articulate exactly what the issue is in an abstract way, so let me provide an example to clarify:
I have a source controlled dotfiles project that lives in ~/dotfiles. Everything inside of ~/dotfiles/dotfiles, including, for example, ~/dotfiles/dotfiles/emacs.d, is pointed at by a symlink in ~ with an identical name (though prefixed with a dot). If a file is opened through the symlinked path, projectile correctly recognizes that the file is part of the ~/dotfiles project, but it then adds the relative path of the file through the symlink (rather than inside of the project) to the project's filepath cache. This means that the file cache gets populated with things like
../.emacs.d/elpa/projectile-20150223.8/projectile.el
Now that I am investigating a bit more, it seems that this only happens with files that are ignored by projectile in the actual directory. It seems that what might be happening is that projectile is not recognizing that the relative filepath ultimately links to a path that is ignored. It might be difficult to come up with a proper resoultion to this issue since you might not always WANT to ignore symlinks that link to other ignored files. However, I would make the argument that any filepath that is outside of the main project should never be added to the projectile file cache.
Sorry if any of this is confusing; let me know if there is anything that needs elucidation.
The text was updated successfully, but these errors were encountered: