Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert worker to use json instead of protobuf #657

Closed
wants to merge 4 commits into from
Closed

Convert worker to use json instead of protobuf #657

wants to merge 4 commits into from

Conversation

keith
Copy link
Member

@keith keith commented Jun 23, 2021

This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516

@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch 2 times, most recently from f601be9 to da58b1c Compare June 23, 2021 22:43
@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch 4 times, most recently from 9173b13 to 1956586 Compare June 24, 2021 00:31
@keith keith marked this pull request as ready for review June 24, 2021 00:47
segiddins
segiddins reviewed Jun 24, 2021
View reviewed changes
arturdryomov
arturdryomov reviewed Jun 24, 2021
View reviewed changes
@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch 2 times, most recently from d340801 to 8b70267 Compare June 26, 2021 00:01
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/ios/builds/713119#5efb817a-9727-4c9b-bd0a-db4ef88ca173 (must be Lyft employee to view)

@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/186 (must be Lyft employee to view)

@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch from 25c3761 to 748f43a Compare November 30, 2021 05:19
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/187 (must be Lyft employee to view)

@brentleyjones
Copy link
Collaborator

Next 5.0rc will have those latest-bazel checks go green.

@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch from 748f43a to 6f2c1b5 Compare January 27, 2022 03:30
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/219 (must be Lyft employee to view)

@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch from 6f2c1b5 to d0fbb2b Compare March 24, 2022 18:26
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/273 (must be Lyft employee to view)

keith added 3 commits April 14, 2022 10:40
@keith
Convert worker to use json instead of protobuf
0523fc6 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
@keith
Add experimental_worker_allow_json_protocol
7f1a966
@keith
ndjson
3c0f5ac
@keith keith force-pushed the ks/convert-worker-to-use-json-instead-of-protobuf branch from d0fbb2b to 3c0f5ac Compare April 14, 2022 17:40
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/300 (must be Lyft employee to view)

@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/301 (must be Lyft employee to view)

@keith keith requested review from brentleyjones and thii April 14, 2022 17:48
@keith keith mentioned this pull request Apr 14, 2022
Merged
@keith
Copy link
Member Author

keith commented Apr 14, 2022

closing for #801

@keith keith closed this Apr 14, 2022
@keith keith deleted the ks/convert-worker-to-use-json-instead-of-protobuf branch April 14, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturdryomov arturdryomov arturdryomov left review comments

@segiddins segiddins segiddins left review comments

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate using json for worker
5 participants
@keith @lyft-lint-bot @brentleyjones @arturdryomov @segiddins