Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using json for worker #516

Closed
keith opened this issue Nov 4, 2020 · 4 comments · Fixed by #801
Closed

Investigate using json for worker #516

keith opened this issue Nov 4, 2020 · 4 comments · Fixed by #801
Labels
P2 We should fix this this quarter

Comments

@keith
Copy link
Member

keith commented Nov 4, 2020

This is supported now and would reduce our usage of proto which can take a while to build on its own. We already have a json parsing library in the worker for output file map manipulation

bazelbuild/bazel#7998 (comment)
@jagobagascon jagobagascon mentioned this issue Jan 28, 2021
Closed
@arturdryomov
Copy link

@keith, do you have ideas about how stable the JSON support gonna be? It would be nice to know or have some insight about whether it will be removed from Bazel itself. I would like to switch from PB to JSON in Detekt rules but not sure if it’s a good idea to require setting a Bazel execution flag (--experimental_worker_allow_json_protocol) from clients. TBH it’s tempting since compiling PB from scratch is a bit ridiculous.

@keith
Copy link
Member Author

keith commented Feb 7, 2021

It was just added so I'm optimistic it will stick around

@arturdryomov
Copy link

@keith, did some digging in buildfoundation/bazel_rules_detekt#107.

@keith
Copy link
Member Author

keith commented Feb 10, 2021

Thanks for the link

keith added a commit that referenced this issue Jun 23, 2021
@keith
Convert worker to use json instead of protobuf
9268bb7 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
@keith keith mentioned this issue Jun 23, 2021
Closed
keith added a commit that referenced this issue Jun 23, 2021
@keith
Convert worker to use json instead of protobuf
f601be9 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Jun 23, 2021
@keith
Convert worker to use json instead of protobuf
da58b1c 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Jun 23, 2021
@keith
Convert worker to use json instead of protobuf
ee35101 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Jun 24, 2021
@keith
Convert worker to use json instead of protobuf
064c0b4 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Jun 24, 2021
@keith
Convert worker to use json instead of protobuf
03b2136 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
@keith keith mentioned this issue Jul 15, 2021
Closed
@keith keith added the P2 We should fix this this quarter label Oct 26, 2021
keith added a commit that referenced this issue Nov 30, 2021
@keith
Convert worker to use json instead of protobuf
0c84d74 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Jan 27, 2022
@keith
Convert worker to use json instead of protobuf
5091002 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Mar 24, 2022
@keith
Convert worker to use json instead of protobuf
11f2d3b 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
keith added a commit that referenced this issue Apr 14, 2022
@keith
Convert worker to use json instead of protobuf
0523fc6 
This was complicated by the difficulty in reading from stdin since it's
populated asynchronously from a file while the worker is running.

Fixes #516
@keith keith mentioned this issue Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We should fix this this quarter
Projects
None yet
Milestone
No milestone
2 participants
@arturdryomov @keith