Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency adapters for virtual targets #277

Merged
merged 2 commits into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ list.

| Last updated | Title | Author(s) alias | Category |
| ------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------- | --------------------- |
| 2022-10-17 | [Dependency adapters for virtual targets](designs/2022-10-17-dependency-adapter.md) | [@vdye](https://github.com/vdye) | Bazel |
| 2022-10-11 | [Renaming applicable_licenses](https://docs.google.com/document/d/1uyJjkKbE8kV8EinakaR9q-Un25zCukhoH_dRBkWHSKQ) | [@aiuto](https://github.com/aiuto) | Configuration |
| 2022-08-03 | [Platforms on Targets](designs/2022-08-03-platforms-on-targets.md) | [@katre](https://github.com/katre) | Configuration |
| 2022-07-07 | [Enabling Global exec_groups](https://github.com/bazelbuild/proposals/new/main/designs/2022-07-07_global_exec_groups.md) | [@susinmotion](https://github.com/susinmotion) | Configurability |
Expand Down
366 changes: 366 additions & 0 deletions designs/2022-10-17-dependency-adapter.md

Large diffs are not rendered by default.

16 changes: 16 additions & 0 deletions images/dependency-adapter/regular-deps.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
@startuml
package "Local Repository" {
[ Executable A ] as A
[ Library B ] as B
}

package "External Repository (shared_libs)" {
[ Library C ] as C
[ Library D ] as D
}

A --> B: <back:white> //B:libB
A -r-> C: <back:white>@shared_libs//C:libC
C --> D: <back:white> //D:libD

@enduml
35 changes: 35 additions & 0 deletions images/dependency-adapter/regular-deps.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions images/dependency-adapter/virtual-deps-with-adapter.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
@startuml
package "Local Repository" {
[ Executable A ] as A
node "dependency adapter" as adapter_local {
cloud "<color:grey>Library B" as B
[ Library B ] as B_concrete
}
}

package "External Repository (shared_libs)" {
node "dependency adapter" as adapter_shared {
cloud "<color:grey>Library C" as C
[ Library C ] as C_concrete
}
[ Library D ] as D
}

A -d-> adapter_local
adapter_local --> B_concrete: <back:white> //B:libB
B .[#grey]r.|> B_concrete: <color:grey>//convert to //\n<color:grey>//concrete //
A -r-> adapter_shared
C .[#grey]d.|> C_concrete: <color:grey>// convert to//\n<color:grey>// concrete//
adapter_shared -r-> C_concrete: <back:white>//@shared_libs~//C:libC //
C_concrete --> D: <back:white> //D:libD

@enduml
Loading