Dependency adapters for virtual targets #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Create the proposal doc in markdown, for review in 'bazelbuild/proposals'.
vdye
force-pushed
the
vdye/dependency-adapter
branch
from
11ae302 to
e86f774
Compare
|
Mind adding a link from the "under review" section of the contents page? |
Listed as "Under review".
lberki
approved these changes
Oct 19, 2022
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 This proposal is intended to address bazelbuild/bazel#16380, following the design review process outlined here.
The document itself is approximately divided into "why I want to do this" (Overview, Background, Concepts) and "how I'd like to do this" (Goals, Implementation, Backward Compatibility). Especially in the first part, I'm interested in whether there are any faulty or incomplete assumptions about Bazel (and, if so, how they should be corrected). I'm happy to clarify or rework anything people would like to discuss, especially if there's a better way to get the behavior I'm looking for.
Finally, I haven't contributed to Bazel before (in case that wasn't obvious 😅), so please let me know if there's anything I can/should do differently to better fit the development and review processes of the project!