Windows, sh_toolchain, bugfix: cast path to string #6508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DetectBashOrDie [1] is commented out from src/main/cpp/blaze.cc, and BAZEL_SH is unset, and PATH is set and "bash" is found on the PATH, then sh_configure successfully finds bash using repository_ctx.which, and this method returns a "path" object. The code used to believe this was a string, and called a string method on it, causing a runtime error. [1] https://github.com/bazelbuild/bazel/blob/2fda17d46088f2bb07b049fa35759002ea1dd5db/src/main/cpp/blaze.cc#L1543 Fixes bazelbuild#6498 Change-Id: I07fd36fd6c6e8433257b0394f1fc776bbe3e6928
meteorcloudy
approved these changes
Oct 25, 2018
|
Thanks for helping with the repro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DetectBashOrDie [1] is commented out from
src/main/cpp/blaze.cc, and BAZEL_SH is unset,
and PATH is set and "bash" is found on the PATH,
then sh_configure successfully finds bash using
repository_ctx.which, and this method returns a
"path" object.
The code used to believe this was a string, and
called a string method on it, causing a runtime
error.
[1]
bazel/src/main/cpp/blaze.cc
Line 1543 in 2fda17d
Fixes #6498
Change-Id: I07fd36fd6c6e8433257b0394f1fc776bbe3e6928