Windows: building C++ hello-world requires local_config_sh

[meteorcloudy]

To reproduce

1. Apply Windows: windows_cc_configure.bzl no longer fails when BAZEL_SH isn't set #6497
2. Comment out the line

   bazel/src/main/cpp/blaze.cc

   Line 1543 in 2fda17d

   DetectBashOrDie();

3. Build Bazel
4. Unset BAZEL_SH (with set BAZEL_SH=)
5. Run bazel build examples/cpp:hello-world

pcloudy@pcloudy0-w MSYS ~/workspace/my_tests/bazel
$ bazel build examples/cpp:hello-world
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
C:\Users\pcloudy/.bazelrc
INFO: Invocation ID: eff13024-3f65-4713-8ef2-108ea283b391
INFO: Build options have changed, discarding analysis cache.
ERROR: While resolving toolchains for target //examples/cpp:hello-world: invalid registered toolchain '@local_config_sh//:local_sh_toolchain': no such package '@local_config_sh//': type 'path' has no method startswith(string)
ERROR: Analysis of target '//examples/cpp:hello-world' failed; build aborted: invalid registered toolchain '@local_config_sh//:local_sh_toolchain': no such package '@local_config_sh//': type 'path' has no method startswith(string)
INFO: Elapsed time: 0.223s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 18 targets configured)
    Fetching @local_config_sh; fetching...

[laszlocsomor]

Thanks for filing this! It's a bad first-time user experience, so I'm linking #5254.

[laszlocsomor]

I can't seem to repro this :S

Here's my source tree:

$ pwd
/c/src/bazel

$ git log -2 --oneline
eb75c814b1 (HEAD) Adrress review comments
983d96d8ec Add msys_gcc_installation_error.bat

And the diff:

diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc
index 9a3396cbd5..df8c455ca7 100644
--- a/src/main/cpp/blaze.cc
+++ b/src/main/cpp/blaze.cc
@@ -1540,7 +1540,7 @@ int Main(int argc, const char *argv[], WorkspaceLayout *workspace_layout,
   // Must be done before command line parsing.
   // ParseOptions already populate --client_env, so detect bash before it
   // happens.
-  DetectBashOrDie();
+  // DetectBashOrDie();

   globals->binary_path = CheckAndGetBinaryPath(argv[0]);
   ParseOptions(argc, argv);

I built Bazel here, then used it like so:

C:\src\bazel>set
JAVA_HOME=C:\Program Files\Java\jdk1.8.0_152
SystemDrive=C:
SystemRoot=C:\WINDOWS

C:\src\bazel>c:\_bazel\o2bbs3hu\execroot\io_bazel\bazel-out\x64_windows-fastbuild\bin\src\bazel.exe --output_user_root=c:\tmp1 build //examples/cpp:hello-world
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
C:\Users\laszlocsomor/.bazelrc
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 368e5bae-ea5f-4527-9d75-12fcec5b3c81
DEBUG: C:/tmp1/o2bbs3hu/external/bazel_tools/tools/cpp/lib_cc_configure.bzl:115:5:
Auto-Configuration Warning: 'PROGRAMFILES(X86)' environment variable is not set, using 'C:\Program Files (x86)' as default
DEBUG: C:/tmp1/o2bbs3hu/external/bazel_tools/tools/cpp/lib_cc_configure.bzl:115:5:
Auto-Configuration Warning: 'TMP' environment variable is not set, using 'C:\Windows\Temp' as default
INFO: Analysed target //examples/cpp:hello-world (7 packages loaded, 71 targets configured).
INFO: Found 1 target...
Target //examples/cpp:hello-world up-to-date:
  C:/tmp1/o2bbs3hu/execroot/io_bazel/bazel-out/x64_windows-fastbuild/bin/examples/cpp/hello-world.exe
INFO: Elapsed time: 14.219s, Critical Path: 3.11s
INFO: 4 processes: 4 local.
INFO: Build completed successfully, 9 total actions

[meteorcloudy]

I tried again and I am still able to reproduce this issue.
Since #6497 is merged, can you sync to BAZEL HEAD and retry?