Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage output generator to coverage_output_generator-v2.7. #24593

Closed
wants to merge 1 commit into from

Conversation

c-mita
Copy link
Member

@c-mita c-mita commented Dec 6, 2024

Built at commit 82c1ff7.

Relevant changes:

RELNOTES: Baseline coverage files are no longer ignored.

@c-mita c-mita requested review from meteorcloudy and fmeum December 6, 2024 16:35
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 6, 2024
@fmeum
Copy link
Collaborator

fmeum commented Dec 6, 2024

@c-mita Looks like the release has been built with a JDK 21, not 11.

@c-mita
Copy link
Member Author

c-mita commented Dec 6, 2024

@c-mita Looks like the release has been built with a JDK 21, not 11.

Ah, the script needs another update.

@c-mita c-mita force-pushed the cov_gen_v2.7 branch 6 times, most recently from 5f8105e to 5fddfdc Compare December 10, 2024 16:11
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Dec 10, 2024
copybara-service bot pushed a commit that referenced this pull request Dec 11, 2024
Check that the actual coverage data simply contains the expected
coverage data, rather than checking for an exact match. This matters
for when we start to process baseline coverage, which may result in
header files getting included in the report. This is in-keeping with
the other coverage tests.

Also adds the branch data into the reports, which we will check when
we're using an LLVM version that supports branch coverage, and a test
that checks header files that include coverage data are actually
included in the final report.

Required for #24593

Closes #24624.

PiperOrigin-RevId: 7051775
Change-Id: I2247434d0b005f2218761249238e52597a452e12
Built at commit 82c1ff7.

Relevant changes:
 * Log level for many messages changed from INFO to FINE (bazelbuild#22257).
 * IOExceptions are no longer ignored (bazelbuild#21987).
 * Baseline coverage files are not ignored (bazelbuild#24563).

RELNOTES: Baseline coverage files are no longer ignored.
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 12, 2024
@fmeum
Copy link
Collaborator

fmeum commented Dec 12, 2024

@bazel-io fork 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants