-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swallowed I/O exception in LcovPrinter #21987
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
...st/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/LcovPrinter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24ffd1a
to
2f5e353
Compare
Squashed to correct email - no diff. Functional TestCoverage roll-up
To sanity check this is the correct override:
Inspect the output report:
All files are present:
|
@bazel-io fork 7.2.0 |
The calling code expects the exception, not a return boolean. Fixes bazelbuild#21982. Closes bazelbuild#21987. PiperOrigin-RevId: 626086576 Change-Id: I4abd7a253715c84c323e036dfbdb2fcb94a4825d
The calling code expects the exception, not a return boolean. Fixes #21982. Closes #21987. PiperOrigin-RevId: 626086576 Change-Id: I4abd7a253715c84c323e036dfbdb2fcb94a4825d Commit f8277cf Co-authored-by: Spencer Putt <[email protected]>
The calling code expects the exception, not a return boolean. Fixes bazelbuild#21982. Closes bazelbuild#21987. PiperOrigin-RevId: 626086576 Change-Id: I4abd7a253715c84c323e036dfbdb2fcb94a4825d
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 93e76f2. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit b09335b. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 82c1ff7. Relevant changes: * Log level for many messages changed from INFO to FINE (bazelbuild#22257). * IOExceptions are no longer ignored (bazelbuild#21987). * Baseline coverage files are not ignored (bazelbuild#24563). RELNOTES: Baseline coverage files are no longer ignored.
Built at commit 82c1ff7. Relevant changes: * Log level for many messages changed from INFO to FINE (#22257). * IOExceptions are no longer ignored (#21987). * Baseline coverage files are not ignored (#24563). RELNOTES: Baseline coverage files are no longer ignored. Closes #24593. PiperOrigin-RevId: 705492845 Change-Id: I6f7b99ec0f040f93cc148c9c8448d4395729adac
This fixes issue #21982