Add --incompatible_java_info_merge_runtime_module_flags #20037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
timothyg-stripe
force-pushed
the
java_info_incompatible
branch
from
521dbb0 to
c3a7e6a
Compare
sgowroji
added
awaiting-user-response
hvadehra
approved these changes
Nov 16, 2023
hvadehra
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.0.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Nov 17, 2023
Change the behavior of `JavaInfo` constructor to be more like `java_info_for_compilation`, by merging in the `add_exports` and `add_opens` flags for `runtime_deps` in addition to just `deps` and `exports`. Guard it under an `--incompatible_` flag which defaults to false, but I'm hoping to make it default to true in 8.x. Second half of bazelbuild#20033 Closes bazelbuild#20037. PiperOrigin-RevId: 582982387 Change-Id: Ibff680f71efed82f20da7d9ee83f0bfa7e5f5697
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Nov 17, 2023
Change the behavior of `JavaInfo` constructor to be more like `java_info_for_compilation`, by merging in the `add_exports` and `add_opens` flags for `runtime_deps` in addition to just `deps` and `exports`. Guard it under an `--incompatible_` flag which defaults to false, but I'm hoping to make it default to true in 8.x. Second half of bazelbuild#20033 Closes bazelbuild#20037. PiperOrigin-RevId: 582982387 Change-Id: Ibff680f71efed82f20da7d9ee83f0bfa7e5f5697
timothyg-stripe
added a commit
to timothyg-stripe/bazel
that referenced
this pull request
Nov 18, 2023
Change the behavior of `JavaInfo` constructor to be more like `java_info_for_compilation`, by merging in the `add_exports` and `add_opens` flags for `runtime_deps` in addition to just `deps` and `exports`. Guard it under an `--incompatible_` flag which defaults to false, but I'm hoping to make it default to true in 8.x. Second half of bazelbuild#20033 Closes bazelbuild#20037. PiperOrigin-RevId: 582982387 Change-Id: Ibff680f71efed82f20da7d9ee83f0bfa7e5f5697
timothyg-stripe
added a commit
to timothyg-stripe/bazel
that referenced
this pull request
Nov 18, 2023
Change the behavior of `JavaInfo` constructor to be more like `java_info_for_compilation`, by merging in the `add_exports` and `add_opens` flags for `runtime_deps` in addition to just `deps` and `exports`. Guard it under an `--incompatible_` flag which defaults to false, but I'm hoping to make it default to true in 8.x. Second half of bazelbuild#20033 Closes bazelbuild#20037. PiperOrigin-RevId: 582982387 Change-Id: Ibff680f71efed82f20da7d9ee83f0bfa7e5f5697
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of
JavaInfoconstructor to be more likejava_info_for_compilation, by merging in theadd_exportsandadd_opensflags forruntime_depsin addition to justdepsandexports. Guard it under an--incompatible_flag which defaults to false, but I'm hoping to make it default to true in 8.x.Second half of #20033