Add add_exports & add_opens parameters to JavaInfo constructor #20036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
@hvadehra can we put this behind the same allowlist as Otherwise it seems fine, there isn't a principled reason this can be configured with |
github-actions
bot
removed
the
awaiting-review
|
@bazel-io fork 7.0.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Nov 17, 2023
There is currently no non-hacky way for third-party rule implementations to add `add_exports` and `add_opens` to a `JavaInfo`, though hacky ways exist (like using a macro to generate a `java_library` with `add_exports` / `add_opens` and add it as a dependency). Having an official way to create `JavaInfo`s with `add_exports` and `add_opens` helps third-party JVM rules better support JDK 9+ (and especially 17+, which requires `--add-opens` flags to access JDK internals through reflection). Addresses half of bazelbuild#20033. Closes bazelbuild#20036. PiperOrigin-RevId: 580472097 Change-Id: I159e3410c5480ac683fd9af85bfd1d83ac0e6d8a
timothyg-stripe
added a commit
to timothyg-stripe/bazel
that referenced
this pull request
Nov 18, 2023
There is currently no non-hacky way for third-party rule implementations to add `add_exports` and `add_opens` to a `JavaInfo`, though hacky ways exist (like using a macro to generate a `java_library` with `add_exports` / `add_opens` and add it as a dependency). Having an official way to create `JavaInfo`s with `add_exports` and `add_opens` helps third-party JVM rules better support JDK 9+ (and especially 17+, which requires `--add-opens` flags to access JDK internals through reflection). Addresses half of bazelbuild#20033. Closes bazelbuild#20036. PiperOrigin-RevId: 580472097 Change-Id: I159e3410c5480ac683fd9af85bfd1d83ac0e6d8a
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no non-hacky way for third-party rule implementations to add
add_exportsandadd_opensto aJavaInfo, though hacky ways exist (like using a macro to generate ajava_librarywithadd_exports/add_opensand add it as a dependency, or creating an empty source file and compiling it usingjava_common.compile).Having an official way to create
JavaInfos withadd_exportsandadd_openshelps third-party JVM rules better support JDK 9+ (and especially 17+, which requires--add-opensflags to access JDK internals through reflection).Addresses half of #20033.