Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analyze-profile phase summary format #15889

Closed
wants to merge 1 commit into from
Closed

Fix analyze-profile phase summary format #15889

wants to merge 1 commit into from

Conversation

rsalvador
Copy link
Contributor

The current output of bazel analyze-profile ... is not properly formatted and looks like:

=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%

this fixes it to:

=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              1.486 s    0.51%
Total init phase time                                0.422 s    0.15%
Total target pattern evaluation phase time           6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time                         0.376 s    0.13%
Total execution phase time                         180.205 s   62.33%
Total finish phase time                              0.086 s    0.03%
---------------------------------------------------------------------
Total run time                                     289.121 s  100.00%

Fixes #15888

@sgowroji sgowroji added team-Performance Issues for Performance teams awaiting-user-response Awaiting a response from the author labels Jul 18, 2022
@rsalvador
Copy link
Contributor Author

@sgowroji the test failure is unrelated to the changes and looks like a flapping test. Do I need to do anything regarding it?

@sgowroji sgowroji removed the awaiting-user-response Awaiting a response from the author label Jul 19, 2022
@rsalvador rsalvador deleted the rsalvador/analyze-profile branch July 20, 2022 14:52
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
@rsalvador @aranguyen
Fix analyze-profile phase summary format
02d57a8 
The current output of `bazel analyze-profile ...` is not properly formatted and looks like:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%
```

this fixes it to:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              1.486 s    0.51%
Total init phase time                                0.422 s    0.15%
Total target pattern evaluation phase time           6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time                         0.376 s    0.13%
Total execution phase time                         180.205 s   62.33%
Total finish phase time                              0.086 s    0.03%
---------------------------------------------------------------------
Total run time                                     289.121 s  100.00%
```

Fixes bazelbuild#15888

Closes bazelbuild#15889.

PiperOrigin-RevId: 462086875
Change-Id: I2be6829e4e1566d6db1322fc6c19b4345a552ed7
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
@rsalvador @aranguyen
Fix analyze-profile phase summary format
1cbeebd 
The current output of `bazel analyze-profile ...` is not properly formatted and looks like:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%
```

this fixes it to:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              1.486 s    0.51%
Total init phase time                                0.422 s    0.15%
Total target pattern evaluation phase time           6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time                         0.376 s    0.13%
Total execution phase time                         180.205 s   62.33%
Total finish phase time                              0.086 s    0.03%
---------------------------------------------------------------------
Total run time                                     289.121 s  100.00%
```

Fixes bazelbuild#15888

Closes bazelbuild#15889.

PiperOrigin-RevId: 462086875
Change-Id: I2be6829e4e1566d6db1322fc6c19b4345a552ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrc-google larsrc-google larsrc-google approved these changes

Assignees
No one assigned
Labels
team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The analyze-profile output is not properly formatted
3 participants
@rsalvador @larsrc-google @sgowroji